mirror of
https://github.com/torvalds/linux.git
synced 2026-05-27 00:22:00 +02:00
30984ccf31
The da_monitor helper functions are generated from macros of the type:
DECLARE_DA_FUNCTION(name, type) \
static void da_func_x_##name(type arg) {} \
static void da_func_y_##name(type arg) {} \
This is good to minimise code duplication but the long macros made of
skipped end of lines is rather hard to parse. Since functions are
static, the advantage of naming them differently for each monitor is
minimal.
Refactor the da_monitor.h file to minimise macros, instead of declaring
functions from macros, we simply declare them with the same name for all
monitors (e.g. da_func_x) and for any remaining reference to the monitor
name (e.g. tracepoints, enums, global variables) we use the CONCATENATE
macro.
In this way the file is much easier to maintain while keeping the same
generality.
Functions depending on the monitor types are now conditionally compiled
according to the value of RV_MON_TYPE, which must be defined in the
monitor source.
The monitor type can be specified as in the original implementation,
although it's best to keep the default implementation (unsigned char) as
not all parts of code support larger data types, and likely there's no
need.
We keep the empty macro definitions to ease review of this change with
diff tools, but cleanup is required.
Also adapt existing monitors to keep the build working.
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://lore.kernel.org/r/20251126104241.291258-2-gmonaco@redhat.com
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
94 lines
2.3 KiB
C
94 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/ftrace.h>
|
|
#include <linux/tracepoint.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/rv.h>
|
|
#include <rv/instrumentation.h>
|
|
|
|
#define MODULE_NAME "snep"
|
|
|
|
#include <trace/events/sched.h>
|
|
#include <trace/events/preemptirq.h>
|
|
#include <rv_trace.h>
|
|
#include <monitors/sched/sched.h>
|
|
|
|
#define RV_MON_TYPE RV_MON_PER_CPU
|
|
#include "snep.h"
|
|
#include <rv/da_monitor.h>
|
|
|
|
static void handle_preempt_disable(void *data, unsigned long ip, unsigned long parent_ip)
|
|
{
|
|
da_handle_start_event(preempt_disable_snep);
|
|
}
|
|
|
|
static void handle_preempt_enable(void *data, unsigned long ip, unsigned long parent_ip)
|
|
{
|
|
da_handle_start_event(preempt_enable_snep);
|
|
}
|
|
|
|
static void handle_schedule_entry(void *data, bool preempt)
|
|
{
|
|
da_handle_event(schedule_entry_snep);
|
|
}
|
|
|
|
static void handle_schedule_exit(void *data, bool is_switch)
|
|
{
|
|
da_handle_start_event(schedule_exit_snep);
|
|
}
|
|
|
|
static int enable_snep(void)
|
|
{
|
|
int retval;
|
|
|
|
retval = da_monitor_init();
|
|
if (retval)
|
|
return retval;
|
|
|
|
rv_attach_trace_probe("snep", preempt_disable, handle_preempt_disable);
|
|
rv_attach_trace_probe("snep", preempt_enable, handle_preempt_enable);
|
|
rv_attach_trace_probe("snep", sched_entry_tp, handle_schedule_entry);
|
|
rv_attach_trace_probe("snep", sched_exit_tp, handle_schedule_exit);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void disable_snep(void)
|
|
{
|
|
rv_this.enabled = 0;
|
|
|
|
rv_detach_trace_probe("snep", preempt_disable, handle_preempt_disable);
|
|
rv_detach_trace_probe("snep", preempt_enable, handle_preempt_enable);
|
|
rv_detach_trace_probe("snep", sched_entry_tp, handle_schedule_entry);
|
|
rv_detach_trace_probe("snep", sched_exit_tp, handle_schedule_exit);
|
|
|
|
da_monitor_destroy();
|
|
}
|
|
|
|
static struct rv_monitor rv_this = {
|
|
.name = "snep",
|
|
.description = "schedule does not enable preempt.",
|
|
.enable = enable_snep,
|
|
.disable = disable_snep,
|
|
.reset = da_monitor_reset_all,
|
|
.enabled = 0,
|
|
};
|
|
|
|
static int __init register_snep(void)
|
|
{
|
|
return rv_register_monitor(&rv_this, &rv_sched);
|
|
}
|
|
|
|
static void __exit unregister_snep(void)
|
|
{
|
|
rv_unregister_monitor(&rv_this);
|
|
}
|
|
|
|
module_init(register_snep);
|
|
module_exit(unregister_snep);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Gabriele Monaco <gmonaco@redhat.com>");
|
|
MODULE_DESCRIPTION("snep: schedule does not enable preempt.");
|