mirror of
https://github.com/torvalds/linux.git
synced 2026-10-17 06:20:02 +02:00
7c16117808
The TX path rounds the transfer size up to the bus alignment
(align_size(), up to 511 bytes for SDIO, 1 byte for SPI) but sends
the padded length straight from the frame buffer, which has no room
reserved for the padding. cw1200_data_write() therefore reads past
the end of the frame and the bus transfer carries those bytes to the
device. A bogus device can collect up to 511 bytes of kernel heap
data per TX frame.
The RX path does not have this problem: it allocates the skb with
the aligned length (alloc_len) before reading.
Compute the exact padding with the bus align_size() callback, make
sure queued TX frames have tailroom for it, and zero the padding
bytes before the transfer so nothing past the frame is exposed.
This is not expected to change driver behavior on most cases: frame
contents and transfer sizes are unchanged, only the content of the
padding bytes (previously undefined stale memory, now zero), which
the device never reads since the WSM header carries the real frame
length. The skb expansion can only fail under memory exhaustion,
in which case the frame is dropped like on the existing error paths
of cw1200_tx().
Discovered by Atuin - Automated Vulnerability Discovery Engine.
Fixes:
|
||
|---|---|---|
| .. | ||
| bh.c | ||
| bh.h | ||
| cw1200_sdio.c | ||
| cw1200_spi.c | ||
| cw1200.h | ||
| debug.c | ||
| debug.h | ||
| fwio.c | ||
| fwio.h | ||
| hwbus.h | ||
| hwio.c | ||
| hwio.h | ||
| Kconfig | ||
| main.c | ||
| Makefile | ||
| pm.c | ||
| pm.h | ||
| queue.c | ||
| queue.h | ||
| scan.c | ||
| scan.h | ||
| sta.c | ||
| sta.h | ||
| txrx.c | ||
| txrx.h | ||
| wsm.c | ||
| wsm.h | ||