mirror of
https://github.com/torvalds/linux.git
synced 2026-05-31 10:33:41 +02:00
Both the data path (ndo_open/ndo_stop) and the upcoming admin channel need to enable and disable the vNIC device independently. Without reference counting, closing the admin channel while the netdev is up would inadvertently disable the entire device. Add an enable_count to struct enic, protected by the existing devcmd_lock. enic_dev_enable() issues CMD_ENABLE_WAIT only on the first caller (0 -> 1 transition), and enic_dev_disable() issues CMD_DISABLE only when the last caller releases (1 -> 0 transition). Also check the return value of enic_dev_enable() in enic_open() and fail the open if the firmware enable command fails. Without this check, a failed enable leaves enable_count at zero while the interface appears up, which can cause a later admin channel enable/disable cycle to incorrectly disable the hardware under the active data path. Signed-off-by: Satish Kharat <satishkh@cisco.com> Link: https://patch.msgid.link/20260401-enic-sriov-v2-prep-v4-4-d5834b2ef1b9@cisco.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
231 lines
4.5 KiB
C
231 lines
4.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
// Copyright 2011 Cisco Systems, Inc. All rights reserved.
|
|
|
|
#include <linux/pci.h>
|
|
#include <linux/etherdevice.h>
|
|
|
|
#include "vnic_dev.h"
|
|
#include "vnic_vic.h"
|
|
#include "enic_res.h"
|
|
#include "enic.h"
|
|
#include "enic_dev.h"
|
|
|
|
int enic_dev_fw_info(struct enic *enic, struct vnic_devcmd_fw_info **fw_info)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_fw_info(enic->vdev, fw_info);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_stats_dump(struct enic *enic, struct vnic_stats **vstats)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_stats_dump(enic->vdev, vstats);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_add_station_addr(struct enic *enic)
|
|
{
|
|
int err;
|
|
|
|
if (!is_valid_ether_addr(enic->netdev->dev_addr))
|
|
return -EADDRNOTAVAIL;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_add_addr(enic->vdev, enic->netdev->dev_addr);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_del_station_addr(struct enic *enic)
|
|
{
|
|
int err;
|
|
|
|
if (!is_valid_ether_addr(enic->netdev->dev_addr))
|
|
return -EADDRNOTAVAIL;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_del_addr(enic->vdev, enic->netdev->dev_addr);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_packet_filter(struct enic *enic, int directed, int multicast,
|
|
int broadcast, int promisc, int allmulti)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_packet_filter(enic->vdev, directed,
|
|
multicast, broadcast, promisc, allmulti);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_add_addr(struct enic *enic, const u8 *addr)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_add_addr(enic->vdev, addr);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_del_addr(struct enic *enic, const u8 *addr)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_del_addr(enic->vdev, addr);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_notify_unset(struct enic *enic)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_notify_unset(enic->vdev);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_hang_notify(struct enic *enic)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_hang_notify(enic->vdev);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_set_ig_vlan_rewrite_mode(struct enic *enic)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_set_ig_vlan_rewrite_mode(enic->vdev,
|
|
IG_VLAN_REWRITE_MODE_PRIORITY_TAG_DEFAULT_VLAN);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_enable(struct enic *enic)
|
|
{
|
|
int err = 0;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
if (enic->enable_count == 0)
|
|
err = vnic_dev_enable_wait(enic->vdev);
|
|
if (!err)
|
|
enic->enable_count++;
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_disable(struct enic *enic)
|
|
{
|
|
int err = 0;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
if (enic->enable_count == 0) {
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
return 0;
|
|
}
|
|
enic->enable_count--;
|
|
if (enic->enable_count == 0)
|
|
err = vnic_dev_disable(enic->vdev);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_intr_coal_timer_info(struct enic *enic)
|
|
{
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = vnic_dev_intr_coal_timer_info(enic->vdev);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
/* rtnl lock is held */
|
|
int enic_vlan_rx_add_vid(struct net_device *netdev, __be16 proto, u16 vid)
|
|
{
|
|
struct enic *enic = netdev_priv(netdev);
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = enic_add_vlan(enic, vid);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
/* rtnl lock is held */
|
|
int enic_vlan_rx_kill_vid(struct net_device *netdev, __be16 proto, u16 vid)
|
|
{
|
|
struct enic *enic = netdev_priv(netdev);
|
|
int err;
|
|
|
|
spin_lock_bh(&enic->devcmd_lock);
|
|
err = enic_del_vlan(enic, vid);
|
|
spin_unlock_bh(&enic->devcmd_lock);
|
|
|
|
return err;
|
|
}
|
|
|
|
int enic_dev_status_to_errno(int devcmd_status)
|
|
{
|
|
switch (devcmd_status) {
|
|
case ERR_SUCCESS:
|
|
return 0;
|
|
case ERR_EINVAL:
|
|
return -EINVAL;
|
|
case ERR_EFAULT:
|
|
return -EFAULT;
|
|
case ERR_EPERM:
|
|
return -EPERM;
|
|
case ERR_EBUSY:
|
|
return -EBUSY;
|
|
case ERR_ECMDUNKNOWN:
|
|
case ERR_ENOTSUPPORTED:
|
|
return -EOPNOTSUPP;
|
|
case ERR_EBADSTATE:
|
|
return -EINVAL;
|
|
case ERR_ENOMEM:
|
|
return -ENOMEM;
|
|
case ERR_ETIMEDOUT:
|
|
return -ETIMEDOUT;
|
|
case ERR_ELINKDOWN:
|
|
return -ENETDOWN;
|
|
case ERR_EINPROGRESS:
|
|
return -EINPROGRESS;
|
|
case ERR_EMAXRES:
|
|
default:
|
|
return (devcmd_status < 0) ? devcmd_status : -1;
|
|
}
|
|
}
|