mirror of
https://github.com/torvalds/linux.git
synced 2026-10-16 12:50:02 +02:00
1caceeb2d7
rxe_get_mcg() publishes a newly allocated multicast group in
rxe->mcg_tree before programming the backing Ethernet multicast address
with rxe_mcast_add(), which runs outside mcg_lock. A local userspace
RDMA client reaches this path with ATTACH_MCAST on a UD QP; if
rxe_mcast_add() then returns an error (for example -ENODEV when the
backing netdev has been removed, or a propagated dev_mc_add() error),
the unwind frees the published group without removing it from the tree.
A later lookup of the same MGID dereferences the freed struct rxe_mcg
from __rxe_lookup_mcg().
Fix this by keeping the new mcg private until rxe_mcast_add() succeeds.
Split the tree publication into __rxe_publish_mcg(), call rxe_mcast_add()
before taking the tree reference, and free the still-private mcg on
failure. Because the group is never visible in mcg_tree until the
multicast address is programmed, no concurrent caller can look it up or
attach a QP to a group that is about to be torn down, so the error path
needs no conditional unwind. If another caller publishes the same MGID
while the address is being programmed, the post-add re-check under
mcg_lock finds the winner; this caller then drops its private object and
balances its own rxe_mcast_add() with rxe_mcast_del() before returning
the winner.
Reproduced by forcing the rxe_mcast_add() error return under KASAN:
without the change the next attach to the same MGID reports a
slab-use-after-free in __rxe_lookup_mcg(); with it the forced failure
returns cleanly. A no-injection attach/detach regression, including a
two-QP shared join/leave and re-attach, stays KASAN- and leak-clean.
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| rxe_av.c | ||
| rxe_comp.c | ||
| rxe_cq.c | ||
| rxe_hdr.h | ||
| rxe_hw_counters.c | ||
| rxe_hw_counters.h | ||
| rxe_icrc.c | ||
| rxe_loc.h | ||
| rxe_mad.c | ||
| rxe_mcast.c | ||
| rxe_mmap.c | ||
| rxe_mr.c | ||
| rxe_mw.c | ||
| rxe_net.c | ||
| rxe_net.h | ||
| rxe_ns.c | ||
| rxe_ns.h | ||
| rxe_odp.c | ||
| rxe_opcode.c | ||
| rxe_opcode.h | ||
| rxe_param.h | ||
| rxe_pool.c | ||
| rxe_pool.h | ||
| rxe_qp.c | ||
| rxe_queue.c | ||
| rxe_queue.h | ||
| rxe_recv.c | ||
| rxe_req.c | ||
| rxe_resp.c | ||
| rxe_srq.c | ||
| rxe_task.c | ||
| rxe_task.h | ||
| rxe_verbs.c | ||
| rxe_verbs.h | ||
| rxe.c | ||
| rxe.h | ||