mirror of
https://github.com/torvalds/linux.git
synced 2026-09-24 06:24:02 +02:00
297b5b747a
The driver defines two device classes: "hfi1" (mode 0600) and
"hfi1_user" (mode 0666), selected by a user_accessible parameter to
hfi1_cdev_init(). The only caller always passes user_accessible=true,
so the "hfi1" class is registered but never used.
The 0600 class was originally used by the diagnostics UI char device
(hfi1_ui*), but that was removed over 10 years ago in commit
7312f29d8e ("IB/hfi1: Remove UI char device"). The class and the
user_accessible parameter were left behind.
Remove the unused class and the user_accessible parameter.
Now that there's only one class, it might make sense to change its name
from "hfi1_user" to just "hfi1", but not knowing whether userspace would
mind, keep the name as is.
Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Link: https://patch.msgid.link/20260701150510.384858-1-mschmidt@redhat.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
105 lines
2.1 KiB
C
105 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
|
|
/*
|
|
* Copyright(c) 2015, 2016 Intel Corporation.
|
|
*/
|
|
|
|
#include <linux/cdev.h>
|
|
#include <linux/device.h>
|
|
#include <linux/fs.h>
|
|
|
|
#include "hfi.h"
|
|
#include "device.h"
|
|
|
|
static char *hfi1_user_devnode(const struct device *dev, umode_t *mode)
|
|
{
|
|
if (mode)
|
|
*mode = 0666;
|
|
return kasprintf(GFP_KERNEL, "%s", dev_name(dev));
|
|
}
|
|
|
|
static const struct class user_class = {
|
|
.name = "hfi1_user",
|
|
.devnode = hfi1_user_devnode,
|
|
};
|
|
static dev_t hfi1_dev;
|
|
|
|
int hfi1_cdev_init(int minor, const char *name,
|
|
const struct file_operations *fops,
|
|
struct cdev *cdev, struct device **devp,
|
|
struct kobject *parent)
|
|
{
|
|
const dev_t dev = MKDEV(MAJOR(hfi1_dev), minor);
|
|
struct device *device = NULL;
|
|
int ret;
|
|
|
|
cdev_init(cdev, fops);
|
|
cdev->owner = THIS_MODULE;
|
|
cdev_set_parent(cdev, parent);
|
|
kobject_set_name(&cdev->kobj, name);
|
|
|
|
ret = cdev_add(cdev, dev, 1);
|
|
if (ret < 0) {
|
|
pr_err("Could not add cdev for minor %d, %s (err %d)\n",
|
|
minor, name, -ret);
|
|
goto done;
|
|
}
|
|
|
|
device = device_create(&user_class, NULL, dev, NULL, "%s", name);
|
|
|
|
if (IS_ERR(device)) {
|
|
ret = PTR_ERR(device);
|
|
pr_err("Could not create device for minor %d, %s (err %pe)\n",
|
|
minor, name, device);
|
|
device = NULL;
|
|
cdev_del(cdev);
|
|
}
|
|
done:
|
|
*devp = device;
|
|
return ret;
|
|
}
|
|
|
|
void hfi1_cdev_cleanup(struct cdev *cdev, struct device **devp)
|
|
{
|
|
struct device *device = *devp;
|
|
|
|
if (device) {
|
|
device_unregister(device);
|
|
*devp = NULL;
|
|
|
|
cdev_del(cdev);
|
|
}
|
|
}
|
|
|
|
static const char *hfi1_class_name = "hfi1";
|
|
|
|
const char *class_name(void)
|
|
{
|
|
return hfi1_class_name;
|
|
}
|
|
|
|
int __init dev_init(void)
|
|
{
|
|
int ret;
|
|
|
|
ret = alloc_chrdev_region(&hfi1_dev, 0, HFI1_NMINORS, DRIVER_NAME);
|
|
if (ret < 0) {
|
|
pr_err("Could not allocate chrdev region (err %d)\n", -ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = class_register(&user_class);
|
|
if (ret) {
|
|
pr_err("Could not create device class for user accessible files (err %d)\n",
|
|
-ret);
|
|
unregister_chrdev_region(hfi1_dev, HFI1_NMINORS);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
void dev_cleanup(void)
|
|
{
|
|
class_unregister(&user_class);
|
|
unregister_chrdev_region(hfi1_dev, HFI1_NMINORS);
|
|
}
|