mirror of
https://github.com/torvalds/linux.git
synced 2026-05-14 01:08:22 +02:00
400a84e1f7
Convert the driver to use the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridges. This modernizes the driver by delegating connector creation to the bridge subsystem through drm_bridge_connector_init() instead of manually searching for connectors created by the bridge. The custom tilcdc_encoder_find_connector() function is removed and replaced with the standard drm_bridge_connector infrastructure, which simplifies the code and aligns with current DRM bridge best practices. This change is safe as there are now no in-tree devicetrees that connect tilcdc to bridges which do not support the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com> Link: https://patch.msgid.link/20260123-feature_tilcdc-v5-25-5a44d2aa3f6f@bootlin.com Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
70 lines
1.7 KiB
C
70 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2015 Texas Instruments
|
|
* Author: Jyri Sarha <jsarha@ti.com>
|
|
*/
|
|
|
|
#include <linux/of_graph.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_bridge.h>
|
|
#include <drm/drm_bridge_connector.h>
|
|
#include <drm/drm_of.h>
|
|
#include <drm/drm_simple_kms_helper.h>
|
|
|
|
#include "tilcdc_drv.h"
|
|
#include "tilcdc_encoder.h"
|
|
|
|
static
|
|
int tilcdc_attach_bridge(struct drm_device *ddev, struct drm_bridge *bridge)
|
|
{
|
|
struct tilcdc_drm_private *priv = ddev_to_tilcdc_priv(ddev);
|
|
struct drm_connector *connector;
|
|
int ret;
|
|
|
|
priv->encoder->base.possible_crtcs = BIT(0);
|
|
|
|
ret = drm_bridge_attach(&priv->encoder->base, bridge, NULL,
|
|
DRM_BRIDGE_ATTACH_NO_CONNECTOR);
|
|
if (ret)
|
|
return ret;
|
|
|
|
connector = drm_bridge_connector_init(ddev, &priv->encoder->base);
|
|
if (IS_ERR(connector)) {
|
|
drm_err(ddev, "bridge_connector create failed\n");
|
|
return PTR_ERR(connector);
|
|
}
|
|
|
|
ret = drm_connector_attach_encoder(connector, &priv->encoder->base);
|
|
if (ret) {
|
|
drm_err(ddev, "attaching encoder to connector failed\n");
|
|
return ret;
|
|
}
|
|
|
|
priv->connector = connector;
|
|
return 0;
|
|
}
|
|
|
|
int tilcdc_encoder_create(struct drm_device *ddev)
|
|
{
|
|
struct tilcdc_drm_private *priv = ddev_to_tilcdc_priv(ddev);
|
|
struct tilcdc_encoder *encoder;
|
|
struct drm_bridge *bridge;
|
|
|
|
bridge = devm_drm_of_get_bridge(ddev->dev, ddev->dev->of_node, 0, 0);
|
|
if (PTR_ERR(bridge) == -ENODEV)
|
|
return 0;
|
|
else if (IS_ERR(bridge))
|
|
return PTR_ERR(bridge);
|
|
|
|
encoder = drmm_simple_encoder_alloc(ddev, struct tilcdc_encoder,
|
|
base, DRM_MODE_ENCODER_NONE);
|
|
if (IS_ERR(encoder)) {
|
|
drm_err(ddev, "drm_encoder_init() failed %pe\n", encoder);
|
|
return PTR_ERR(encoder);
|
|
}
|
|
priv->encoder = encoder;
|
|
|
|
return tilcdc_attach_bridge(ddev, bridge);
|
|
}
|