mirror of
https://github.com/torvalds/linux.git
synced 2026-10-16 04:39:02 +02:00
6502eb8cfc
komeda_dev_resume() calls clk_prepare_enable() without checking the return value. If the clock fails to enable, the function returns 0 (success) while IRQs are enabled and IOMMU is connected on potentially unclocked hardware, causing undefined behavior on resume. Propagate the error from clk_prepare_enable() and fix all call sites in komeda_drv.c that previously ignored the return value of komeda_dev_resume(): - komeda_platform_probe(): if resume fails, jump to err_destroy_mdev (skipping the suspend call, since the clock was never enabled) - komeda_pm_resume(): propagate the error and skip drm_mode_config_helper_resume() on failure This issue was found by code review without access to Komeda hardware. Signed-off-by: Gustavo Kenji Mendonça Kaneko <kaneko.dev@pm.me> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Link: https://patch.msgid.link/20260609130828.1066038-1-kaneko.dev@pm.me Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> |
||
|---|---|---|
| .. | ||
| d71 | ||
| komeda_color_mgmt.c | ||
| komeda_color_mgmt.h | ||
| komeda_crtc.c | ||
| komeda_dev.c | ||
| komeda_dev.h | ||
| komeda_drv.c | ||
| komeda_event.c | ||
| komeda_format_caps.c | ||
| komeda_format_caps.h | ||
| komeda_framebuffer.c | ||
| komeda_framebuffer.h | ||
| komeda_kms.c | ||
| komeda_kms.h | ||
| komeda_pipeline_state.c | ||
| komeda_pipeline.c | ||
| komeda_pipeline.h | ||
| komeda_plane.c | ||
| komeda_private_obj.c | ||
| komeda_wb_connector.c | ||
| Makefile | ||