mirror of
https://github.com/torvalds/linux.git
synced 2026-05-12 16:18:45 +02:00
7e555fcae4
Two allocations in __regmap_init_ram() are not cleaned up on failure.
If the kzalloc_objs() for data->written fails, data->read is returned
with no way for the caller to free it.
If __regmap_init() fails, neither data->read nor data->written is freed
because its error paths do not call bus->free_context() (which is
regmap_ram_free_context() here). Only regmap_exit() does, and that is
never reached on an init failure.
Free the allocated arrays before returning any error.
Fixes: f6352424e3 ("regmap: Add RAM backed register map")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Link: https://patch.msgid.link/20260416235630.78408-1-dbgh9129@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
92 lines
1.9 KiB
C
92 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// Register map access API - Memory region
|
|
//
|
|
// This is intended for testing only
|
|
//
|
|
// Copyright (c) 2023, Arm Ltd
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/module.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/swab.h>
|
|
|
|
#include "internal.h"
|
|
|
|
static int regmap_ram_write(void *context, unsigned int reg, unsigned int val)
|
|
{
|
|
struct regmap_ram_data *data = context;
|
|
|
|
data->vals[reg] = val;
|
|
data->written[reg] = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int regmap_ram_read(void *context, unsigned int reg, unsigned int *val)
|
|
{
|
|
struct regmap_ram_data *data = context;
|
|
|
|
*val = data->vals[reg];
|
|
data->read[reg] = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void regmap_ram_free_context(void *context)
|
|
{
|
|
struct regmap_ram_data *data = context;
|
|
|
|
kfree(data->vals);
|
|
kfree(data->read);
|
|
kfree(data->written);
|
|
kfree(data);
|
|
}
|
|
|
|
static const struct regmap_bus regmap_ram = {
|
|
.fast_io = true,
|
|
.reg_write = regmap_ram_write,
|
|
.reg_read = regmap_ram_read,
|
|
.free_context = regmap_ram_free_context,
|
|
};
|
|
|
|
struct regmap *__regmap_init_ram(struct device *dev,
|
|
const struct regmap_config *config,
|
|
struct regmap_ram_data *data,
|
|
struct lock_class_key *lock_key,
|
|
const char *lock_name)
|
|
{
|
|
struct regmap *map;
|
|
|
|
if (!config->max_register) {
|
|
pr_crit("No max_register specified for RAM regmap\n");
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
data->read = kzalloc_objs(bool, config->max_register + 1);
|
|
if (!data->read)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
data->written = kzalloc_objs(bool, config->max_register + 1);
|
|
if (!data->written) {
|
|
kfree(data->read);
|
|
return ERR_PTR(-ENOMEM);
|
|
}
|
|
|
|
map = __regmap_init(dev, ®map_ram, data, config,
|
|
lock_key, lock_name);
|
|
if (IS_ERR(map)) {
|
|
kfree(data->read);
|
|
kfree(data->written);
|
|
}
|
|
|
|
return map;
|
|
}
|
|
EXPORT_SYMBOL_GPL(__regmap_init_ram);
|
|
|
|
MODULE_DESCRIPTION("Register map access API - Memory region");
|
|
MODULE_LICENSE("GPL v2");
|