mirror of
https://github.com/torvalds/linux.git
synced 2026-09-24 06:24:02 +02:00
1160c2208f
If an empty firmware file is supplied via CONFIG_EXTRA_FIRMWARE, the build currently succeeds but creates an empty section. While the firmware loader will not return such sections it is better to avoid adding them in the first place. Add a compile-time size check to the filechk_fwbin macro to abort the build early if a 0-size firmware is encountered. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Link: https://patch.msgid.link/20260426043041.649202-2-dmitry.torokhov@gmail.com [ Use 'exit 1' to properly fail the build. - Danilo ] Signed-off-by: Danilo Krummrich <dakr@kernel.org>
47 lines
1.7 KiB
Makefile
47 lines
1.7 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
obj-y += main.o
|
|
|
|
# Create $(fwdir) from $(CONFIG_EXTRA_FIRMWARE_DIR) -- if it doesn't have a
|
|
# leading /, it's relative to $(srctree).
|
|
fwdir := $(CONFIG_EXTRA_FIRMWARE_DIR)
|
|
fwdir := $(addprefix $(srctree)/,$(filter-out /%,$(fwdir)))$(filter /%,$(fwdir))
|
|
|
|
firmware := $(addsuffix .gen.o, $(CONFIG_EXTRA_FIRMWARE))
|
|
obj-y += $(firmware)
|
|
|
|
FWNAME = $(patsubst $(obj)/%.gen.S,%,$@)
|
|
FWSTR = $(subst $(comma),_,$(subst /,_,$(subst .,_,$(subst -,_,$(FWNAME)))))
|
|
ASM_WORD = $(if $(CONFIG_64BIT),.quad,.long)
|
|
ASM_ALIGN = $(if $(CONFIG_64BIT),3,2)
|
|
PROGBITS = $(if $(CONFIG_ARM),%,@)progbits
|
|
|
|
filechk_fwbin = \
|
|
if [ ! -s "$(fwdir)/$(FWNAME)" ]; then \
|
|
echo "error: empty firmware: $(fwdir)/$(FWNAME)" >&2 ;\
|
|
exit 1 ;\
|
|
fi ;\
|
|
echo "/* Generated by $(src)/Makefile */" ;\
|
|
echo " .section .rodata" ;\
|
|
echo " .p2align 4" ;\
|
|
echo "_fw_$(FWSTR)_bin:" ;\
|
|
echo " .incbin \"$(fwdir)/$(FWNAME)\"" ;\
|
|
echo "_fw_end:" ;\
|
|
echo " .section .rodata.str,\"aMS\",$(PROGBITS),1" ;\
|
|
echo " .p2align $(ASM_ALIGN)" ;\
|
|
echo "_fw_$(FWSTR)_name:" ;\
|
|
echo " .string \"$(FWNAME)\"" ;\
|
|
echo " .section .builtin_fw,\"a\",$(PROGBITS)" ;\
|
|
echo " .p2align $(ASM_ALIGN)" ;\
|
|
echo " $(ASM_WORD) _fw_$(FWSTR)_name" ;\
|
|
echo " $(ASM_WORD) _fw_$(FWSTR)_bin" ;\
|
|
echo " $(ASM_WORD) _fw_end - _fw_$(FWSTR)_bin"
|
|
|
|
$(obj)/%.gen.S: FORCE
|
|
$(call filechk,fwbin)
|
|
|
|
# The .o files depend on the binaries directly; the .S files don't.
|
|
$(addprefix $(obj)/, $(firmware)): $(obj)/%.gen.o: $(fwdir)/%
|
|
|
|
targets := $(patsubst $(obj)/%,%, \
|
|
$(shell find $(obj) -name \*.gen.S 2>/dev/null))
|