Commit Graph

5 Commits

Author SHA1 Message Date
Christian Brauner
07d35cec28 vfs: use __struct_size() in the fdtable KUnit test
sparse doesn't know __builtin_dynamic_object_size() and so the two size
checks in the fdtable test fall apart on every config where the compiler
has __counted_by_ptr:

  fs/tests/fdtable_kunit.c:25:9: sparse: undefined identifier '__builtin_dynamic_object_size'
  fs/tests/fdtable_kunit.c:25:9: sparse: incompatible types for operation (==):

Use __struct_size() instead. Every compiler that has __counted_by_ptr also
has __builtin_dynamic_object_size() so it expands to the same builtin and
the test checks the same thing. sparse lacks the builtin and gets the
__builtin_object_size() fallback which it does understand.

Fixes: 501cbbd276 ("vfs: Add KUnit tests for fdtable")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609111337.fBSfTIpR-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202609111828.SjerhPyO-lkp@intel.com/
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
2026-09-11 14:47:49 +02:00
Bill Wendling
501cbbd276
vfs: Add KUnit tests for fdtable
This adds a KUnit test suite for fdtable to verify correct allocation,
max_fds initialization, and dynamic object size of the fd array under
__counted_by_ptr when CONFIG_CC_HAS_COUNTED_BY_PTR is enabled.

Signed-off-by: Bill Wendling <morbo@google.com>
Link: https://patch.msgid.link/20260827041732.188707-2-morbo@google.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
2026-09-10 09:32:48 +02:00
Kees Cook
c4192754e8 fs/tests: exec: Remove bad test vector
Drop an unusable test in the bprm stack limits.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Closes: https://lore.kernel.org/all/a3e9b1c2-40c1-45df-9fa2-14ee6a7b3fe2@roeck-us.net
Fixes: 60371f43e5 ("exec: Add KUnit test for bprm_stack_limits()")
Signed-off-by: Kees Cook <kees@kernel.org>
2026-03-18 11:41:53 -07:00
Titouan Ameline de Cadeville
46a03ea50b fs/tests: exec: drop duplicate bprm_stack_limits test vectors
Remove duplicate entries from the bprm_stack_limits KUnit test vector
table. The duplicates do not add coverage and only increase test size.

Signed-off-by: Titouan Ameline de Cadeville <titouan.ameline@gmail.com>
Fixes: 60371f43e5 ("exec: Add KUnit test for bprm_stack_limits()")
Link: https://patch.msgid.link/20260203175950.43710-1-titouan.ameline@gmail.com
Signed-off-by: Kees Cook <kees@kernel.org>
2026-02-03 17:39:00 -08:00
Kees Cook
b6f5ee4d53 execve: Move KUnit tests to tests/ subdirectory
Move the exec KUnit tests into a separate directory to avoid polluting
the local directory namespace. Additionally update MAINTAINERS for the
new files.

Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Acked-by: Christian Brauner <brauner@kernel.org>
Link: https://lore.kernel.org/r/20240720170310.it.942-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
2024-07-22 18:25:47 -07:00