Commit Graph

10 Commits

Author SHA1 Message Date
Binbin Zhou
3c5ddd56aa
ASoC: codecs: es8323: Enable proper DAPM widgets for chip power
Remove initialization of the chip power register from the
es8323_set_bias_level routine, and add proper DAPM power supply widgets
to DAPM, which really should be handled by the DAPM subsystem.

Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://patch.msgid.link/db47e56e7c72bb900a84a33ee07d4ffcf0a908a3.1768641428.git.zhoubinbin@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
2026-01-19 14:42:16 +00:00
Binbin Zhou
95814d4b8d
ASoC: codecs: es8323: Enable proper DAPM widgets for capture ADC
Add proper DAPM capture ADC widgets to DAPM, which really should be
handled by the DAPM subsystem.

Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://patch.msgid.link/9d93040f4cea77054e669c50325e080dffa7a7f1.1768641428.git.zhoubinbin@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
2026-01-19 14:42:15 +00:00
Binbin Zhou
9dd2719a9a
ASoC: codecs: es8323: remove DAC enablement write from es8323_set_bias_level
Since commit daf855f76a ("ASoC: es8323: enable DAPM power widgets for
playback DAC"), the DAC is handled by the DAPM subsystem.

Remove initialization of the DAC enablement bits from the
es8323_set_bias_level routine

Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://patch.msgid.link/d2823ad7ae226a83d49bcb860240c0ddc4080f14.1768641428.git.zhoubinbin@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
2026-01-19 14:42:14 +00:00
Binbin Zhou
0cccfe6589
ASoC: codecs: es8323: Replace magic numbers with defined macros
According to the manual, add more detailed register bitfield definitions
to replace the magic numbers in the register settings in es8323 codec.

No functional change intended.

Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://patch.msgid.link/7e8953f2d36a86e9d507d6bb01c72b64846e0829.1768641428.git.zhoubinbin@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
2026-01-19 14:42:13 +00:00
Shimrra Shai
daf855f76a
ASoC: es8323: enable DAPM power widgets for playback DAC
This part might not be needed for resubmission as it was already
accepted on the previous submission of this patch, but since the whole
series was not accepted due to that I had retained and expanded the
initialization in the probe routine I'm not sure if I should submit
it again.

Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
Link: https://patch.msgid.link/20250815042023.115485-4-shimrrashai@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2025-08-18 13:10:00 +01:00
Shimrra Shai
7e39ca4056
ASoC: es8323: add proper left/right mixer controls via DAPM
Add proper DAC and mixer controls to DAPM; no initialization in
es8323_probe.

Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
Link: https://patch.msgid.link/20250815042023.115485-3-shimrrashai@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2025-08-18 13:09:59 +01:00
Shimrra Shai
33bc29123d
ASoC: es8323: remove DAC enablement write from es8323_probe
Remove initialization of the DAC and mixer enablement bits from the
es8323_probe routine. This really should be handled by the DAPM
subsystem.

Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
Link: https://patch.msgid.link/20250815042023.115485-2-shimrrashai@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2025-08-18 13:09:58 +01:00
Uwe Kleine-König
8359ea9c11
ASoC: Drop explicit initialization of struct i2c_device_id::driver_data to 0
These drivers don't use the driver_data member of struct i2c_device_id,
so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires
either no initialization or named designators. But it's also a nice
cleanup on its own.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20241202113641.1003836-2-u.kleine-koenig@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2024-12-02 17:58:37 +00:00
Tang Bin
c178920970
ASoC: codecs: Fix error check in es8323_i2c_probe
In the function es8323_i2c_probe(), devm_kzalloc() could
possibly return NULL pointer, so IS_ERR() is wrong check
in this place, thus fix it.

Fixes: b97391a604 ("ASoC: codecs: Add support for ES8323")
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://patch.msgid.link/20241011073115.2384-1-tangbin@cmss.chinamobile.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2024-10-11 11:22:46 +01:00
Binbin Zhou
b97391a604
ASoC: codecs: Add support for ES8323
Add a codec driver for the Everest ES8323. It supports two separate
audio outputs and two separate audio inputs.

Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://patch.msgid.link/135b19b06d19f34af8a0419bd3782ce5b8779870.1728459624.git.zhoubinbin@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
2024-10-09 14:40:49 +01:00