mirror of
https://github.com/torvalds/linux.git
synced 2026-09-24 06:24:02 +02:00
sched_ext: Add reenq_flags plumbing to scx_bpf_dsq_reenq()
Add infrastructure to pass flags through the deferred reenqueue path. reenq_local() now takes a reenq_flags parameter, and scx_sched_pcpu gains a deferred_reenq_local_flags field to accumulate flags from multiple scx_bpf_dsq_reenq() calls before processing. No flags are defined yet. Signed-off-by: Tejun Heo <tj@kernel.org> Reviewed-by: Andrea Righi <arighi@nvidia.com>
This commit is contained in:
parent
9c34c5074d
commit
ffa7ae0724
|
|
@ -1080,7 +1080,8 @@ static void schedule_deferred_locked(struct rq *rq)
|
||||||
schedule_deferred(rq);
|
schedule_deferred(rq);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void schedule_dsq_reenq(struct scx_sched *sch, struct scx_dispatch_q *dsq)
|
static void schedule_dsq_reenq(struct scx_sched *sch, struct scx_dispatch_q *dsq,
|
||||||
|
u64 reenq_flags)
|
||||||
{
|
{
|
||||||
/*
|
/*
|
||||||
* Allowing reenqueues doesn't make sense while bypassing. This also
|
* Allowing reenqueues doesn't make sense while bypassing. This also
|
||||||
|
|
@ -1097,6 +1098,7 @@ static void schedule_dsq_reenq(struct scx_sched *sch, struct scx_dispatch_q *dsq
|
||||||
scoped_guard (raw_spinlock_irqsave, &rq->scx.deferred_reenq_lock) {
|
scoped_guard (raw_spinlock_irqsave, &rq->scx.deferred_reenq_lock) {
|
||||||
if (list_empty(&drl->node))
|
if (list_empty(&drl->node))
|
||||||
list_move_tail(&drl->node, &rq->scx.deferred_reenq_locals);
|
list_move_tail(&drl->node, &rq->scx.deferred_reenq_locals);
|
||||||
|
drl->flags |= reenq_flags;
|
||||||
}
|
}
|
||||||
|
|
||||||
schedule_deferred(rq);
|
schedule_deferred(rq);
|
||||||
|
|
@ -3617,7 +3619,14 @@ static void process_ddsp_deferred_locals(struct rq *rq)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
static u32 reenq_local(struct scx_sched *sch, struct rq *rq)
|
static bool task_should_reenq(struct task_struct *p, u64 reenq_flags)
|
||||||
|
{
|
||||||
|
if (reenq_flags & SCX_REENQ_ANY)
|
||||||
|
return true;
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
static u32 reenq_local(struct scx_sched *sch, struct rq *rq, u64 reenq_flags)
|
||||||
{
|
{
|
||||||
LIST_HEAD(tasks);
|
LIST_HEAD(tasks);
|
||||||
u32 nr_enqueued = 0;
|
u32 nr_enqueued = 0;
|
||||||
|
|
@ -3651,6 +3660,9 @@ static u32 reenq_local(struct scx_sched *sch, struct rq *rq)
|
||||||
if (!scx_is_descendant(task_sch, sch))
|
if (!scx_is_descendant(task_sch, sch))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
|
if (!task_should_reenq(p, reenq_flags))
|
||||||
|
continue;
|
||||||
|
|
||||||
dispatch_dequeue(rq, p);
|
dispatch_dequeue(rq, p);
|
||||||
list_add_tail(&p->scx.dsq_list.node, &tasks);
|
list_add_tail(&p->scx.dsq_list.node, &tasks);
|
||||||
}
|
}
|
||||||
|
|
@ -3670,6 +3682,7 @@ static void process_deferred_reenq_locals(struct rq *rq)
|
||||||
|
|
||||||
while (true) {
|
while (true) {
|
||||||
struct scx_sched *sch;
|
struct scx_sched *sch;
|
||||||
|
u64 reenq_flags = 0;
|
||||||
|
|
||||||
scoped_guard (raw_spinlock, &rq->scx.deferred_reenq_lock) {
|
scoped_guard (raw_spinlock, &rq->scx.deferred_reenq_lock) {
|
||||||
struct scx_deferred_reenq_local *drl =
|
struct scx_deferred_reenq_local *drl =
|
||||||
|
|
@ -3684,10 +3697,11 @@ static void process_deferred_reenq_locals(struct rq *rq)
|
||||||
sch_pcpu = container_of(drl, struct scx_sched_pcpu,
|
sch_pcpu = container_of(drl, struct scx_sched_pcpu,
|
||||||
deferred_reenq_local);
|
deferred_reenq_local);
|
||||||
sch = sch_pcpu->sch;
|
sch = sch_pcpu->sch;
|
||||||
|
swap(drl->flags, reenq_flags);
|
||||||
list_del_init(&drl->node);
|
list_del_init(&drl->node);
|
||||||
}
|
}
|
||||||
|
|
||||||
reenq_local(sch, rq);
|
reenq_local(sch, rq, reenq_flags);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -7816,7 +7830,7 @@ __bpf_kfunc u32 scx_bpf_reenqueue_local(const struct bpf_prog_aux *aux)
|
||||||
rq = cpu_rq(smp_processor_id());
|
rq = cpu_rq(smp_processor_id());
|
||||||
lockdep_assert_rq_held(rq);
|
lockdep_assert_rq_held(rq);
|
||||||
|
|
||||||
return reenq_local(sch, rq);
|
return reenq_local(sch, rq, 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
__bpf_kfunc_end_defs();
|
__bpf_kfunc_end_defs();
|
||||||
|
|
@ -8254,8 +8268,17 @@ __bpf_kfunc void scx_bpf_dsq_reenq(u64 dsq_id, u64 reenq_flags,
|
||||||
if (unlikely(!sch))
|
if (unlikely(!sch))
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
if (unlikely(reenq_flags & ~__SCX_REENQ_USER_MASK)) {
|
||||||
|
scx_error(sch, "invalid SCX_REENQ flags 0x%llx", reenq_flags);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* not specifying any filter bits is the same as %SCX_REENQ_ANY */
|
||||||
|
if (!(reenq_flags & __SCX_REENQ_FILTER_MASK))
|
||||||
|
reenq_flags |= SCX_REENQ_ANY;
|
||||||
|
|
||||||
dsq = find_dsq_for_dispatch(sch, this_rq(), dsq_id, smp_processor_id());
|
dsq = find_dsq_for_dispatch(sch, this_rq(), dsq_id, smp_processor_id());
|
||||||
schedule_dsq_reenq(sch, dsq);
|
schedule_dsq_reenq(sch, dsq, reenq_flags);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
||||||
|
|
@ -956,6 +956,7 @@ struct scx_dsp_ctx {
|
||||||
|
|
||||||
struct scx_deferred_reenq_local {
|
struct scx_deferred_reenq_local {
|
||||||
struct list_head node;
|
struct list_head node;
|
||||||
|
u64 flags;
|
||||||
};
|
};
|
||||||
|
|
||||||
struct scx_sched_pcpu {
|
struct scx_sched_pcpu {
|
||||||
|
|
@ -1128,6 +1129,15 @@ enum scx_deq_flags {
|
||||||
SCX_DEQ_SCHED_CHANGE = 1LLU << 33,
|
SCX_DEQ_SCHED_CHANGE = 1LLU << 33,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
enum scx_reenq_flags {
|
||||||
|
/* low 16bits determine which tasks should be reenqueued */
|
||||||
|
SCX_REENQ_ANY = 1LLU << 0, /* all tasks */
|
||||||
|
|
||||||
|
__SCX_REENQ_FILTER_MASK = 0xffffLLU,
|
||||||
|
|
||||||
|
__SCX_REENQ_USER_MASK = SCX_REENQ_ANY,
|
||||||
|
};
|
||||||
|
|
||||||
enum scx_pick_idle_cpu_flags {
|
enum scx_pick_idle_cpu_flags {
|
||||||
SCX_PICK_IDLE_CORE = 1LLU << 0, /* pick a CPU whose SMT siblings are also idle */
|
SCX_PICK_IDLE_CORE = 1LLU << 0, /* pick a CPU whose SMT siblings are also idle */
|
||||||
SCX_PICK_IDLE_IN_NODE = 1LLU << 1, /* pick a CPU in the same target NUMA node */
|
SCX_PICK_IDLE_IN_NODE = 1LLU << 1, /* pick a CPU in the same target NUMA node */
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user