github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-04 20:46:48 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

xfs: don't call xfs_can_free_eofblocks from ->release for zoned inodes

Browse Source 
Zoned file systems require out of place writes and thus can't support
post-EOF speculative preallocations.  Avoid the pointless ilock critical
section to find out that none can be freed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
This commit is contained in:
Christoph Hellwig 2024-11-21 08:50:23 +01:00
parent f044dda351
commit fc04408c47
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
fs/xfs/xfs_file.c
View File

@ -1356,15 +1356,22 @@ xfs_file_release(
* blocks. This avoids open/read/close workloads from removing EOF * blocks. This avoids open/read/close workloads from removing EOF
* blocks that other writers depend upon to reduce fragmentation. * blocks that other writers depend upon to reduce fragmentation.
* *
* Inodes on the zoned RT device never have preallocations, so skip
* taking the locks below.
*/
if (!inode->i_nlink ||
!(file->f_mode & FMODE_WRITE) ||
(ip->i_diflags & XFS_DIFLAG_APPEND) ||
xfs_is_zoned_inode(ip))
return 0;
/*
* If we can't get the iolock just skip truncating the blocks past EOF * If we can't get the iolock just skip truncating the blocks past EOF
* because we could deadlock with the mmap_lock otherwise. We'll get * because we could deadlock with the mmap_lock otherwise. We'll get
* another chance to drop them once the last reference to the inode is * another chance to drop them once the last reference to the inode is
* dropped, so we'll never leak blocks permanently. * dropped, so we'll never leak blocks permanently.
*/ */
if (inode->i_nlink && if (!xfs_iflags_test(ip, XFS_EOFBLOCKS_RELEASED) &&
(file->f_mode & FMODE_WRITE) &&
!(ip->i_diflags & XFS_DIFLAG_APPEND) &&
!xfs_iflags_test(ip, XFS_EOFBLOCKS_RELEASED) &&
xfs_ilock_nowait(ip, XFS_IOLOCK_EXCL)) { xfs_ilock_nowait(ip, XFS_IOLOCK_EXCL)) {
if (xfs_can_free_eofblocks(ip) && if (xfs_can_free_eofblocks(ip) &&
!xfs_iflags_test_and_set(ip, XFS_EOFBLOCKS_RELEASED)) !xfs_iflags_test_and_set(ip, XFS_EOFBLOCKS_RELEASED))