github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 00:53:34 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mshv: Allow mappings that overlap in uaddr

Browse Source 
Currently the MSHV driver rejects mappings that would overlap in
userspace.

Some VMMs require the same memory to be mapped to different parts of
the guest's address space, and so working around this restriction is
difficult.

The hypervisor itself doesn't prohibit mappings that overlap in uaddr,
(really in SPA; system physical addresses), so supporting this in the
driver doesn't require any extra work: only the checks need to be
removed.

Since no userspace code until now has been able to overlap regions in
userspace, relaxing this constraint can't break any existing code.

Signed-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Wei Liu <wei.liu@kernel.org>
This commit is contained in:
Magnus Kulke 2025-11-06 14:13:31 -08:00 committed by Wei Liu
parent ba9eb9b86d
commit f91bc8f61a
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/hv/mshv_root_main.c
View File

@ -1188,12 +1188,8 @@ static int mshv_partition_create_region(struct mshv_partition *partition,
/* Reject overlapping regions */
hlist_for_each_entry(rg, &partition->pt_mem_regions, hnode) {
u64 rg_size = rg->nr_pages << HV_HYP_PAGE_SHIFT;
if ((mem->guest_pfn + nr_pages <= rg->start_gfn ||
rg->start_gfn + rg->nr_pages <= mem->guest_pfn) &&
(mem->userspace_addr + mem->size <= rg->start_uaddr ||
rg->start_uaddr + rg_size <= mem->userspace_addr))
if (mem->guest_pfn + nr_pages <= rg->start_gfn ||
rg->start_gfn + rg->nr_pages <= mem->guest_pfn)
continue;
return -EEXIST;

2
include/uapi/linux/mshv.h
View File

@ -89,7 +89,7 @@ enum {
* @rsvd: MBZ
*
* Map or unmap a region of userspace memory to Guest Physical Addresses (GPA).
* Mappings can't overlap in GPA space or userspace.
* Mappings can't overlap in GPA space.
* To unmap, these fields must match an existing mapping.
*/
struct mshv_user_mem_region {