github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-21 21:37:25 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

pinctrl: cy8c95x0: use flexible sleeping in reset function

Browse Source 
The device reset assert and deassert length was created by usleep_range()
but that does not ensure optimal handling of all the different values from
device tree properties. By switching to the new flexible sleeping helper
function, fsleep(), the correct delay function is called depending on
delay length, e.g. udelay(), usleep_range() or msleep().

While at it, move out GPIO consumer name setting of the reset conditional,
the all necessary checks are already done there, so logically that call is
not related to the reset sequence.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/20241110210040.18918-4-andy.shevchenko@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Andy Shevchenko 2024-11-10 22:59:43 +02:00 committed by Linus Walleij
parent c13411c6fa
commit f8bd5383d8
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/pinctrl/pinctrl-cy8c95x0.c
View File

@ -1475,12 +1475,11 @@ static int cy8c95x0_probe(struct i2c_client *client)
chip->gpio_reset = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(chip->gpio_reset))
return dev_err_probe(chip->dev, PTR_ERR(chip->gpio_reset), "Failed to get GPIO 'reset'\n");
gpiod_set_consumer_name(chip->gpio_reset, "CY8C95X0 RESET");
if (chip->gpio_reset) {
usleep_range(1000, 2000);
fsleep(1000);
gpiod_set_value_cansleep(chip->gpio_reset, 0);
usleep_range(250000, 300000);
gpiod_set_consumer_name(chip->gpio_reset, "CY8C95X0 RESET");
fsleep(250000);
}
/* Regmap for direct and paged registers */