github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/xe: Remove usage of unsafe strcpy

Browse Source 
Remove usage of unsafe strcpy with a helper function
to convert engine class to string.

Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240318091055.638-1-nirmoy.das@intel.com
This commit is contained in:
Nirmoy Das 2024-03-18 10:10:55 +01:00 committed by Matthew Auld
parent 6d74e387aa
commit f87cf2877b
1 changed files with 23 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
View File

@ -499,8 +499,8 @@ static void kobj_xe_hw_engine_class_fini(struct drm_device *drm, void *arg)
kobject_put(kobj);
}
static struct kobj_eclass *
kobj_xe_hw_engine_class(struct xe_device *xe, struct kobject *parent, char *name)
static struct kobj_eclass *
kobj_xe_hw_engine_class(struct xe_device *xe, struct kobject *parent, const char *name)
{
struct kobj_eclass *keclass;
int err = 0;
@ -635,6 +635,24 @@ static void hw_engine_class_sysfs_fini(struct drm_device *drm, void *arg)
kobject_put(kobj);
}
static const char *xe_hw_engine_class_to_str(enum xe_engine_class class)
{
switch (class) {
case XE_ENGINE_CLASS_RENDER:
return "rcs";
case XE_ENGINE_CLASS_VIDEO_DECODE:
return "vcs";
case XE_ENGINE_CLASS_VIDEO_ENHANCE:
return "vecs";
case XE_ENGINE_CLASS_COPY:
return "bcs";
case XE_ENGINE_CLASS_COMPUTE:
return "ccs";
default:
return NULL;
}
}
/**
* xe_hw_engine_class_sysfs_init - Init HW engine classes on GT.
* @gt: Xe GT.
@ -664,7 +682,7 @@ int xe_hw_engine_class_sysfs_init(struct xe_gt *gt)
goto err_object;
for_each_hw_engine(hwe, gt, id) {
char name[MAX_ENGINE_CLASS_NAME_LEN];
const char *name;
struct kobj_eclass *keclass;
if (hwe->class == XE_ENGINE_CLASS_OTHER ||
@ -675,24 +693,8 @@ int xe_hw_engine_class_sysfs_init(struct xe_gt *gt)
continue;
class_mask |= 1 << hwe->class;
switch (hwe->class) {
case XE_ENGINE_CLASS_RENDER:
strcpy(name, "rcs");
break;
case XE_ENGINE_CLASS_VIDEO_DECODE:
strcpy(name, "vcs");
break;
case XE_ENGINE_CLASS_VIDEO_ENHANCE:
strcpy(name, "vecs");
break;
case XE_ENGINE_CLASS_COPY:
strcpy(name, "bcs");
break;
case XE_ENGINE_CLASS_COMPUTE:
strcpy(name, "ccs");
break;
default:
name = xe_hw_engine_class_to_str(hwe->class);
if (!name) {
err = -EINVAL;
goto err_object;
}