From f86641ffea95ee6f62d829929a69be7ab1496ce5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Garc=C3=ADa=20Casado?= Date: Mon, 19 Oct 2026 22:53:44 +0200 Subject: [PATCH] tracing/osnoise: Add __printf attribute to osnoise_print() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Building kernel/trace/trace_osnoise.o with W=1 triggers the following compiler warning: kernel/trace/trace_osnoise.c:96:17: warning: function 'osnoise_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] osnoise_print() forwards its format string and va_list arguments to trace_array_vprintk(), which is annotated with __printf(3, 0). Add the __printf(1, 2) attribute to osnoise_print() to silence the W=1 warning and enable compile-time format string checking for its callers. Link: https://patch.msgid.link/20261019205344.190022-1-adriangarciacasado42@gmail.com Signed-off-by: Adrián García Casado Signed-off-by: Steven Rostedt --- kernel/trace/trace_osnoise.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 0e1265acd1cc..995da9e0b548 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -83,6 +83,7 @@ struct osnoise_instance { static struct list_head osnoise_instances; +__printf(1, 2) static void osnoise_print(const char *fmt, ...) { struct osnoise_instance *inst;