github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 09:36:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

spi: Fix mismatched DT property access types

Browse Source 
The SPI drivers read properties whose bindings use normal uint32 cells.
Using boolean or u16 helpers makes the access look like a different DT
encoding and causes the property checker to flag the call sites.

Use presence checks for unsupported properties and read numeric cell
properties through u32 helpers before assigning to driver fields.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260612215017.1884893-1-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Rob Herring (Arm) 2026-06-12 16:50:17 -05:00 committed by Mark Brown
parent 47f3b53655
commit f846d68992
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/spi/spi-fsl-espi.c
View File

@ -756,7 +756,7 @@ static int of_fsl_espi_probe(struct platform_device *ofdev)
unsigned int irq, num_cs;
int ret;
if (of_property_read_bool(np, "mode")) {
if (of_property_present(np, "mode")) {
dev_err(dev, "mode property is not supported on ESPI!\n");
return -EINVAL;
}

6
drivers/spi/spi-hisi-kunpeng.c
View File

@ -463,6 +463,7 @@ static int hisi_spi_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct spi_controller *host;
struct hisi_spi *hs;
u32 num_cs;
int ret, irq;
irq = platform_get_irq(pdev, 0);
@ -495,10 +496,11 @@ static int hisi_spi_probe(struct platform_device *pdev)
if (host->max_speed_hz == 0)
return dev_err_probe(dev, -EINVAL, "spi-max-frequency can't be 0\n");
ret = device_property_read_u16(dev, "num-cs",
&host->num_chipselect);
ret = device_property_read_u32(dev, "num-cs", &num_cs);
if (ret)
host->num_chipselect = DEFAULT_NUM_CS;
else
host->num_chipselect = num_cs;
host->use_gpio_descriptors = true;
host->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LOOP;