github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-25 07:33:19 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: i2c: ov8856: free control handler on error in ov8856_init_controls()

Browse Source 
The control handler wasn't freed if adding controls failed, add an error
exit label and convert the existing error return to use it.

Fixes: 879347f0c2 ("media: ov8856: Add support for OV8856 sensor")
Cc: stable@vger.kernel.org
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
This commit is contained in:
Alexander Koskovich 2026-03-12 17:16:20 +00:00 committed by Hans Verkuil
parent ea9e61deee
commit f75e160745
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/i2c/ov8856.c
View File

@ -1951,12 +1951,18 @@ static int ov8856_init_controls(struct ov8856 *ov8856)
V4L2_CID_HFLIP, 0, 1, 1, 0);
v4l2_ctrl_new_std(ctrl_hdlr, &ov8856_ctrl_ops,
V4L2_CID_VFLIP, 0, 1, 1, 0);
if (ctrl_hdlr->error)
return ctrl_hdlr->error;
if (ctrl_hdlr->error) {
ret = ctrl_hdlr->error;
goto err_ctrl_handler_free;
}
ov8856->sd.ctrl_handler = ctrl_hdlr;
return 0;
err_ctrl_handler_free:
v4l2_ctrl_handler_free(ctrl_hdlr);
return ret;
}
static void ov8856_update_pad_format(struct ov8856 *ov8856,