From f658c7bd7880ab642e3531f15a5df73fc0519f5f Mon Sep 17 00:00:00 2001 From: Carlos Junior Date: Mon, 28 Sep 2026 10:28:18 -0300 Subject: [PATCH] ata: sata_mv: enable SoC SATA LED presence indication Enable the SoC SATA LED controller in mv_soc_enable_leds(). Set the LED controller enable and device presence multiplexing bits in the SoC SATA host-controller register. This enables SATA device presence indication on boards using the SoC SATA controller. Signed-off-by: Carlos Junior Reviewed-by: Damien Le Moal Link: https://lore.kernel.org/r/20260928133040.222155-1-cjuniorfox@gmail.com Signed-off-by: Niklas Cassel --- drivers/ata/sata_mv.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index d260f04e6384..c408d04d9bf7 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -252,6 +252,7 @@ enum { SOC_LED_CTRL_BLINK = (1 << 0), /* Active LED blink */ SOC_LED_CTRL_ACT_PRESENCE = (1 << 2), /* Multiplex dev presence */ /* with dev activity LED */ + SOC_LED_CTRL_ENABLE = (1 << 3), /* Enable SATA LED control */ /* Shadow block registers */ SHD_BLK = 0x100, @@ -3382,12 +3383,15 @@ static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio, writel(m2, port_mmio + PHY_MODE2); } -/* TODO: use the generic LED interface to configure the SATA Presence */ -/* & Acitivy LEDs on the board */ +/* + * Enable the SoC SATA LED controller and device presence + * indication on the board's SATA LEDs. + */ static void mv_soc_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio) { - return; + writel(SOC_LED_CTRL_ENABLE | SOC_LED_CTRL_ACT_PRESENCE, + mv_hc_base(mmio, 0) + SOC_LED_CTRL); } static void mv_soc_read_preamp(struct mv_host_priv *hpriv, int idx,