mirror of
https://github.com/torvalds/linux.git
synced 2026-09-27 19:42:03 +02:00
s390/cmf: Fix virtual vs physical address confusion
The measurement block address is an absolute address. Define the
associated schib_config and schib fields as dma64_t to enable automatic
detection of incorrect assignments. Also add the missing virt_to_dma64()
translation.
Without this fix, a wrong address will be used by firmware when storing
extended format channel measurement data on kernels built with
CONFIG_RANDOMIZE_IDENTITY_BASE=y.
Fixes: 14edd0d73b ("s390/cmf: fix virtual vs physical address confusion")
Cc: stable@vger.kernel.org
Signed-off-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
This commit is contained in:
parent
3a43be7a1f
commit
f4d04425e6
|
|
@ -7,6 +7,7 @@
|
|||
#include <linux/mod_devicetable.h>
|
||||
#include <asm/chpid.h>
|
||||
#include <asm/cio.h>
|
||||
#include <asm/dma-types.h>
|
||||
#include <asm/fcx.h>
|
||||
#include <asm/schid.h>
|
||||
#include <asm/tpi.h>
|
||||
|
|
@ -49,7 +50,7 @@ struct pmcw {
|
|||
|
||||
/* Target SCHIB configuration. */
|
||||
struct schib_config {
|
||||
u64 mba;
|
||||
dma64_t mba;
|
||||
u32 intparm;
|
||||
u16 mbi;
|
||||
u32 isc:3;
|
||||
|
|
@ -66,7 +67,7 @@ struct schib_config {
|
|||
struct schib {
|
||||
struct pmcw pmcw; /* path management control word */
|
||||
union scsw scsw; /* subchannel status word */
|
||||
__u64 mba; /* measurement block address */
|
||||
dma64_t mba; /* measurement block address */
|
||||
__u8 mda[4]; /* model dependent area */
|
||||
} __attribute__ ((packed,aligned(4)));
|
||||
|
||||
|
|
|
|||
|
|
@ -183,7 +183,7 @@ static int set_schib(struct ccw_device *cdev, u32 mme, int mbfc,
|
|||
sch->config.mbfc = mbfc;
|
||||
/* address can be either a block address or a block index */
|
||||
if (mbfc)
|
||||
sch->config.mba = address;
|
||||
sch->config.mba = address ? virt_to_dma64((void *)address) : 0;
|
||||
else
|
||||
sch->config.mbi = address;
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user