btrfs: avoid unnecessary path allocation when replaying a dir item

There's no need to allocate 'fixup_path' at replay_one_dir_item(), as the
path passed as an argument is unused by the time link_to_fixup_dir() is
called (replay_one_name() releases the path before it returns).

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Filipe Manana 2025-09-01 16:37:05 +01:00 committed by David Sterba
parent b343047c1a
commit f366722f33

View File

@ -2147,18 +2147,10 @@ static noinline int replay_one_dir_item(struct walk_control *wc,
* dentries that can never be deleted.
*/
if (ret == 1 && btrfs_dir_ftype(wc->log_leaf, di) != BTRFS_FT_DIR) {
struct btrfs_path *fixup_path;
struct btrfs_key di_key;
fixup_path = btrfs_alloc_path();
if (!fixup_path) {
btrfs_abort_transaction(wc->trans, -ENOMEM);
return -ENOMEM;
}
btrfs_dir_item_key_to_cpu(wc->log_leaf, di, &di_key);
ret = link_to_fixup_dir(wc, fixup_path, di_key.objectid);
btrfs_free_path(fixup_path);
ret = link_to_fixup_dir(wc, path, di_key.objectid);
}
return ret;