github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-06 21:45:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: fddi: fix UAF in fza_probe

Browse Source 
commit deb7178eb9 upstream.

fp is netdev private data and it cannot be
used after free_netdev() call. Using fp after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() after error message.

Fixes: 61414f5ec9 ("FDDI: defza: Add support for DEC FDDIcontroller 700
TURBOchannel adapter")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Pavel Skripkin 2021-07-13 13:58:53 +03:00 committed by Greg Kroah-Hartman
parent 66c73f187d
commit f33605908a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/fddi/defza.c
View File

@ -1504,9 +1504,8 @@ static int fza_probe(struct device *bdev)
release_mem_region(start, len); release_mem_region(start, len);
err_out_kfree: err_out_kfree:
free_netdev(dev);
pr_err("%s: initialization failure, aborting!\n", fp->name); pr_err("%s: initialization failure, aborting!\n", fp->name);
free_netdev(dev);
return ret; return ret;
} }