From f2267ad5777f36319eeb765afbf015344b24fec2 Mon Sep 17 00:00:00 2001 From: Xin Zhao Date: Wed, 17 Jun 2026 15:21:51 +0800 Subject: [PATCH] sched/fair: Simplify balance_interval reset logic in sched_balance_rq() Because active_balance is initialized to 0, and need_active_balance() is a pre-condition for setting it to 1, the condition '!active_balance || need_active_balance()' is a truism and can be removed. Signed-off-by: Xin Zhao Signed-off-by: Peter Zijlstra (Intel) Link: https://patch.msgid.link/20260617072151.1173416-3-jackzxcui1989@163.com --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7d9ad7853441..ce836ed69759 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -13612,10 +13612,8 @@ static int sched_balance_rq(int this_cpu, struct rq *this_rq, sd->nr_balance_failed = 0; } - if (likely(!active_balance) || need_active_balance(&env)) { - /* We were unbalanced, so reset the balancing interval */ - sd->balance_interval = sd->min_interval; - } + /* We were unbalanced, so reset the balancing interval */ + sd->balance_interval = sd->min_interval; goto out;