github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

habanalabs: remove node from list before freeing the node

Browse Source 
[ Upstream commit f5eb7bf0c4 ]

fix the following smatch warnings:

goya_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list

gaudi_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Koby Elbaz 2021-06-09 21:43:52 +03:00 committed by Greg Kroah-Hartman
parent 25ddb0a42f
commit f22649cf90
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/misc/habanalabs/gaudi/gaudi.c
View File

@ -3708,6 +3708,7 @@ static int gaudi_pin_memory_before_cs(struct hl_device *hdev,
return 0; return 0;
unpin_memory: unpin_memory:
list_del(&userptr->job_node);
hl_unpin_host_memory(hdev, userptr); hl_unpin_host_memory(hdev, userptr);
free_userptr: free_userptr:
kfree(userptr); kfree(userptr);

1
drivers/misc/habanalabs/goya/goya.c
View File

@ -3190,6 +3190,7 @@ static int goya_pin_memory_before_cs(struct hl_device *hdev,
return 0; return 0;
unpin_memory: unpin_memory:
list_del(&userptr->job_node);
hl_unpin_host_memory(hdev, userptr); hl_unpin_host_memory(hdev, userptr);
free_userptr: free_userptr:
kfree(userptr); kfree(userptr);