From f1474f0cb5c0542e13bc613f4657120102709259 Mon Sep 17 00:00:00 2001 From: Sebastian Andrzej Siewior Date: Fri, 18 Sep 2026 12:46:28 +0200 Subject: [PATCH] remoteproc: Use %p for pointer formatting Commit 276ec9934231e ("remoteproc: replace "%p" with "%pK"") introduced the %pK in order to not leak kernel pointers. Since commit ad67b74d2469d ("printk: hash addresses printed with %p") pointers are hashed by default and the behaviour can be controller by `hash_pointers' boot argument. The policy on %p is to not introduce new ones. Removing %pK makes it possible to remove its handling from the library. I doubt printing the address of struct fw_rsc_hdr with an unknown type brings any value. The va is printed already in debug output in other places as %p so it makes probably no difference to remove it from rproc_carveouts_show(). Use %p instead %pK for rproc_mem_entry::va, remove the address of the unknown type. Signed-off-by: Sebastian Andrzej Siewior Link: https://lore.kernel.org/r/20260918104628.jqQhAlF-@linutronix.de Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index b86c1d09c70c..e8e7b6a3769b 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -347,8 +347,8 @@ static int rproc_rsc_table_show(struct seq_file *seq, void *p) } break; default: - seq_printf(seq, "Unknown resource type found: %d [hdr: %pK]\n", - hdr->type, hdr); + seq_printf(seq, "Unknown resource type found: %d\n", + hdr->type); break; } } @@ -367,7 +367,7 @@ static int rproc_carveouts_show(struct seq_file *seq, void *p) list_for_each_entry(carveout, &rproc->carveouts, node) { seq_puts(seq, "Carveout memory entry:\n"); seq_printf(seq, "\tName: %s\n", carveout->name); - seq_printf(seq, "\tVirtual address: %pK\n", carveout->va); + seq_printf(seq, "\tVirtual address: %p\n", carveout->va); seq_printf(seq, "\tDMA address: %pad\n", &carveout->dma); seq_printf(seq, "\tDevice address: 0x%x\n", carveout->da); seq_printf(seq, "\tLength: 0x%zx Bytes\n\n", carveout->len);