mirror of
https://github.com/torvalds/linux.git
synced 2026-10-23 07:11:03 +02:00
ipc: drop the mqueue mount with kern_unmount() on setup failure
mq_init_ns() creates the mqueue mount with fc_mount_longterm(), so its ->mnt_ns is MNT_NS_INTERNAL. When setting up the mqueue or ipc sysctls or msg_init_ns() fails afterwards, create_ipc_ns() drops it with a plain mntput(). With ->mnt_ns set that takes the fast path of mntput_no_expire(). The count drops to zero and nothing ever kills the mount, so the mount and the mqueue superblock are leaked. Commitdc55e35f9e("ipc: Store mqueue sysctls in the ipc namespace") added the first failure path after mq_init_ns() and never dropped the mount. Commit7229d74e5e("ipc: create_ipc_ns: drop mqueue mount on sysctl setup failure") tried to fix that with a mntput() but that doesn't help for a long-term mount. Use kern_unmount(). free_ipc() open-codes the same thing for a namespace that made it. Fixes:dc55e35f9e("ipc: Store mqueue sysctls in the ipc namespace") Fixes:7229d74e5e("ipc: create_ipc_ns: drop mqueue mount on sysctl setup failure") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20261009-work-fixes-rcu-v1-5-7446d2d335e6@kernel.org Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
This commit is contained in:
parent
6e6928b396
commit
f0e48172a5
|
|
@ -96,7 +96,7 @@ static struct ipc_namespace *create_ipc_ns(struct user_namespace *user_ns,
|
|||
fail_mq_sysctls:
|
||||
retire_mq_sysctls(ns);
|
||||
fail_mq_mount:
|
||||
mntput(ns->mq_mnt);
|
||||
kern_unmount(ns->mq_mnt);
|
||||
fail_put:
|
||||
put_user_ns(ns->user_ns);
|
||||
ns_common_free(ns);
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user