github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-25 15:41:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

gpio: it87: use new line value setter callbacks

Browse Source 
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250423-gpiochip-set-rv-gpio-part2-v1-5-b22245cde81a@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Bartosz Golaszewski 2025-04-23 09:15:07 +02:00
parent 40150dda92
commit ef877a1590
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpio/gpio-it87.c
View File

@ -213,8 +213,7 @@ static int it87_gpio_direction_in(struct gpio_chip *chip, unsigned gpio_num)
return rc; return rc;
} }
static void it87_gpio_set(struct gpio_chip *chip, static int it87_gpio_set(struct gpio_chip *chip, unsigned int gpio_num, int val)
unsigned gpio_num, int val)
{ {
u8 mask, curr_vals; u8 mask, curr_vals;
u16 reg; u16 reg;
@ -228,6 +227,8 @@ static void it87_gpio_set(struct gpio_chip *chip,
outb(curr_vals | mask, reg); outb(curr_vals | mask, reg);
else else
outb(curr_vals & ~mask, reg); outb(curr_vals & ~mask, reg);
return 0;
} }
static int it87_gpio_direction_out(struct gpio_chip *chip, static int it87_gpio_direction_out(struct gpio_chip *chip,
@ -249,7 +250,9 @@ static int it87_gpio_direction_out(struct gpio_chip *chip,
/* set the output enable bit */ /* set the output enable bit */
superio_set_mask(mask, group + it87_gpio->output_base); superio_set_mask(mask, group + it87_gpio->output_base);
it87_gpio_set(chip, gpio_num, val); rc = it87_gpio_set(chip, gpio_num, val);
if (rc)
goto exit;
superio_exit(); superio_exit();
@ -264,7 +267,7 @@ static const struct gpio_chip it87_template_chip = {
.request = it87_gpio_request, .request = it87_gpio_request,
.get = it87_gpio_get, .get = it87_gpio_get,
.direction_input = it87_gpio_direction_in, .direction_input = it87_gpio_direction_in,
.set = it87_gpio_set, .set_rv = it87_gpio_set,
.direction_output = it87_gpio_direction_out, .direction_output = it87_gpio_direction_out,
.base = -1 .base = -1
}; };