github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 01:55:51 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

fs/resctrl: Add monitor property 'mbm_cntr_assign_fixed'

Browse Source 
Commit

  3b497c3f4f ("fs/resctrl: Introduce the interface to display monitoring modes")

introduced CONFIG_RESCTRL_ASSIGN_FIXED but left adding the Kconfig
entry until it was necessary. The counter assignment mode is fixed in
MPAM, even when there are assignable counters, and so addressing this
is needed to support MPAM.

To avoid the burden of another Kconfig entry, replace
CONFIG_RESCTRL_ASSIGN_FIXED with a new property in 'struct resctrl_mon',
'mbm_cntr_assign_fixed' to be set by the architecture.

Do not request the architecture to change the counter assignment mode if it
does not support doing so. Provide insight to user space about why such a
request fails.

Signed-off-by: Ben Horgan <ben.horgan@arm.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Link: https://lore.kernel.org/20260506082855.3694761-1-ben.horgan@arm.com
This commit is contained in:
Ben Horgan 2026-05-06 09:28:52 +01:00 committed by Borislav Petkov (AMD)
parent f52abe6502
commit ee3d4c81d8
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/resctrl/monitor.c
View File

@ -1456,7 +1456,7 @@ int resctrl_mbm_assign_mode_show(struct kernfs_open_file *of,
else
seq_puts(s, "[default]\n");
if (!IS_ENABLED(CONFIG_RESCTRL_ASSIGN_FIXED)) {
if (!r->mon.mbm_cntr_assign_fixed) {
if (enabled)
seq_puts(s, "default\n");
else
@ -1507,6 +1507,12 @@ ssize_t resctrl_mbm_assign_mode_write(struct kernfs_open_file *of, char *buf,
}
if (enable != resctrl_arch_mbm_cntr_assign_enabled(r)) {
if (r->mon.mbm_cntr_assign_fixed) {
ret = -EINVAL;
rdt_last_cmd_puts("Counter assignment mode is not configurable\n");
goto out_unlock;
}
ret = resctrl_arch_mbm_cntr_assign_set(r, enable);
if (ret)
goto out_unlock;

2
include/linux/resctrl.h
View File

@ -294,6 +294,7 @@ enum resctrl_schema_fmt {
* @mbm_assign_on_mkdir: True if counters should automatically be assigned to MBM
* events of monitor groups created via mkdir.
* @mbm_cntr_configurable: True if assignable counters are configurable.
* @mbm_cntr_assign_fixed: True if the counter assignment mode is fixed.
*/
struct resctrl_mon {
u32 num_rmid;
@ -302,6 +303,7 @@ struct resctrl_mon {
bool mbm_cntr_assignable;
bool mbm_assign_on_mkdir;
bool mbm_cntr_configurable;
bool mbm_cntr_assign_fixed;
};
/**