github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-06 21:58:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

clk: nomadik: Make sure clk_init_data is fully initialized

Browse Source 
The clk_init_data structure contains several mutually-exclusive members
for different methods to specify the possible parents of a clock,
prompting drivers to initialize only the members they need.  However,
not initializing all members may cause subtle issues, which are only
exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
enabled.

Make sure all members are fully initialized, to avoid such bugs, and to
prevent future breakage when converting drivers to a different method
for specifying the parents.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Linus Walleij <linusw@kernel.org>
Message-ID: <631df13629bf77d55bda770f94c7b1863690f2e2.1787239813.git.geert+renesas@glider.be>
Signed-off-by: Brian Masney <bmasney@redhat.com>
This commit is contained in:
Geert Uytterhoeven 2026-08-21 10:53:32 +02:00 committed by Brian Masney
parent 523fd58a9c
commit ecf7f55166
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/clk/clk-nomadik.c
View File

@ -263,7 +263,7 @@ pll_clk_register(struct device *dev, const char *name,
{
int ret;
struct clk_pll *pll;
struct clk_init_data init;
struct clk_init_data init = {};
if (id != 1 && id != 2) {
pr_err("%s: the Nomadik has only PLL 1 & 2\n", __func__);
@ -355,7 +355,7 @@ src_clk_register(struct device *dev, const char *name,
{
int ret;
struct clk_src *sclk;
struct clk_init_data init;
struct clk_init_data init = {};
sclk = kzalloc_obj(*sclk);
if (!sclk)