github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-06 21:58:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ASoC: apple: Explain DAI startup return value handling

Browse Source 
Add a comment explaining why .startup() must return 0 on success
to ensure the DAI is correctly marked as started and prevent
future changes from reintroducing the issue.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20261016040946.521195-3-phucduc.bui@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
bui duc phuc 2026-10-16 11:09:37 +07:00 committed by Mark Brown
parent 1ba2cb30ee
commit ec2e1434c7
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/apple/mca.c
View File

@ -535,6 +535,11 @@ static int mca_fe_startup(struct snd_pcm_substream *substream,
if (ret < 0)
return ret;
/*
* ASoC only marks the DAI as started when .startup() returns 0.
* Since snd_pcm_hw_constraint_minmax() may return 1, explicitly
* return 0 to ensure the DAI is correctly marked as started.
*/
return 0;
}