github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: saa7134: fix incorrect use to determine if list is empty

Browse Source 
[ Upstream commit 9f1f4b6424 ]

'dev' will *always* be set by list_for_each_entry().
It is incorrect to assume that the iterator value will be NULL if the
list is empty.

Instead of checking the pointer it should be checked if
the list is empty.

Fixes: 79dd0c69f0 ("V4L: 925: saa7134 alsa is now a standalone module")
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jakob Koschel 2022-02-28 15:26:26 +01:00 committed by Greg Kroah-Hartman
parent dd67315994
commit ebd4f1501e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/pci/saa7134/saa7134-alsa.c
View File

@ -1214,7 +1214,7 @@ static int alsa_device_exit(struct saa7134_dev *dev)
static int saa7134_alsa_init(void) static int saa7134_alsa_init(void)
{ {
struct saa7134_dev *dev = NULL; struct saa7134_dev *dev;
saa7134_dmasound_init = alsa_device_init; saa7134_dmasound_init = alsa_device_init;
saa7134_dmasound_exit = alsa_device_exit; saa7134_dmasound_exit = alsa_device_exit;
@ -1229,7 +1229,7 @@ static int saa7134_alsa_init(void)
alsa_device_init(dev); alsa_device_init(dev);
} }
if (dev == NULL) if (list_empty(&saa7134_devlist))
pr_info("saa7134 ALSA: no saa7134 cards found\n"); pr_info("saa7134 ALSA: no saa7134 cards found\n");
return 0; return 0;