github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-05 04:56:13 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mt76: fix possible undetected invalid MAC address

Browse Source 
Make sure the MAC address is checked before function returns.

If CONFIG_OF is set and the device node is null, the function will
return directly, and an invalid MAC address will not be checked.

Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
This commit is contained in:
Shayne Chen 2019-11-26 21:15:54 +08:00 committed by Felix Fietkau
parent 37a68e0015
commit eba571683b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/wireless/mediatek/mt76/eeprom.c
View File

@ -80,13 +80,14 @@ mt76_eeprom_override(struct mt76_dev *dev)
const u8 *mac;
if (!np)
return;
goto out;
mac = of_get_mac_address(np);
if (!IS_ERR(mac))
ether_addr_copy(dev->macaddr, mac);
#endif
out:
if (!is_valid_ether_addr(dev->macaddr)) {
eth_random_addr(dev->macaddr);
dev_info(dev->dev,