github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: qede: use faked extack in qede_flow_spec_to_rule()

Browse Source 
Since qede_parse_flow_attr() now does error reporting
through extack, then give it a fake extack and extract the
error message afterwards if one was set.

The extracted error message is then passed on through
DP_NOTICE(), including messages that was earlier issued
with DP_INFO().

This fake extack approach is already used by
mlxsw_env_linecard_modules_power_mode_apply() in
drivers/net/ethernet/mellanox/mlxsw/core_env.c

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-13-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Asbjørn Sloth Tønnesen 2024-05-08 14:34:00 +00:00 committed by Jakub Kicinski
parent d6883bceb2
commit eb705d7345
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/qlogic/qede/qede_filter.c
View File

@ -1990,6 +1990,7 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
{ {
struct ethtool_rx_flow_spec_input input = {}; struct ethtool_rx_flow_spec_input input = {};
struct ethtool_rx_flow_rule *flow; struct ethtool_rx_flow_rule *flow;
struct netlink_ext_ack extack;
__be16 proto; __be16 proto;
int err; int err;
@ -2017,7 +2018,7 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
if (IS_ERR(flow)) if (IS_ERR(flow))
return PTR_ERR(flow); return PTR_ERR(flow);
err = qede_parse_flow_attr(proto, flow->rule, t, NULL); err = qede_parse_flow_attr(proto, flow->rule, t, &extack);
if (err) if (err)
goto err_out; goto err_out;
@ -2025,6 +2026,8 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
err = qede_flow_spec_validate(edev, &flow->rule->action, t, err = qede_flow_spec_validate(edev, &flow->rule->action, t,
fs->location); fs->location);
err_out: err_out:
if (extack._msg)
DP_NOTICE(edev, "%s\n", extack._msg);
ethtool_rx_flow_rule_destroy(flow); ethtool_rx_flow_rule_destroy(flow);
return err; return err;