github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 11:37:06 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: axis-fifo: Use devm_kasprintf for device name allocation

Browse Source 
Replace manual kzalloc + snprintf with devm_kasprintf, which is
cleaner and purpose-built for this use case.

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Link: https://patch.msgid.link/20251227212640.3321310-3-ovidiu.panait.oss@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ovidiu Panait 2025-12-27 23:26:34 +02:00 committed by Greg Kroah-Hartman
parent c83d8445f3
commit eb12093d42
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/staging/axis-fifo/axis-fifo.c
View File

@ -537,7 +537,6 @@ static int axis_fifo_probe(struct platform_device *pdev)
struct resource *r_mem; /* IO mem resources */
struct device *dev = &pdev->dev; /* OS device (from device tree) */
struct axis_fifo *fifo = NULL;
char *device_name;
int rc = 0; /* error return value */
int irq;
@ -546,10 +545,6 @@ static int axis_fifo_probe(struct platform_device *pdev)
* ----------------------------
*/
device_name = devm_kzalloc(dev, 32, GFP_KERNEL);
if (!device_name)
return -ENOMEM;
/* allocate device wrapper memory */
fifo = devm_kzalloc(dev, sizeof(*fifo), GFP_KERNEL);
if (!fifo)
@ -612,13 +607,17 @@ static int axis_fifo_probe(struct platform_device *pdev)
if (fifo->id < 0)
return fifo->id;
snprintf(device_name, 32, "%s%d", DRIVER_NAME, fifo->id);
/* create character device */
fifo->miscdev.fops = &fops;
fifo->miscdev.minor = MISC_DYNAMIC_MINOR;
fifo->miscdev.name = device_name;
fifo->miscdev.parent = dev;
fifo->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
DRIVER_NAME, fifo->id);
if (!fifo->miscdev.name) {
ida_free(&axis_fifo_ida, fifo->id);
return -ENOMEM;
}
rc = misc_register(&fifo->miscdev);
if (rc < 0) {
ida_free(&axis_fifo_ida, fifo->id);