mirror of
https://github.com/torvalds/linux.git
synced 2026-05-26 08:02:27 +02:00
smb: smbdirect: introduce smbdirect_connection_recv_io_done()
This is basically a copy of recv_done() in client and server, with the following additions: - Only handling the SMBDIRECT_EXPECT_DATA_TRANSFER code path, as we'll have separate functions for the negotiate messages. - Using more helper variables - Improved logging - Add credits_requested == 0 error check - Add data_offset not 8 bytes aligned error check - Use disable_work(&sc->recv_io.posted.refill_work) before smbdirect_connection_put_recv_io, when it is followed by smbdirect_socket_schedule_cleanup() This will be used on common between client and server in future and replace the existing recv_done() functions. Cc: Steve French <smfrench@gmail.com> Cc: Tom Talpey <tom@talpey.com> Cc: Long Li <longli@microsoft.com> Cc: Namjae Jeon <linkinjeon@kernel.org> Cc: linux-cifs@vger.kernel.org Cc: samba-technical@lists.samba.org Signed-off-by: Stefan Metzmacher <metze@samba.org> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Stefan Metzmacher
Steve French
parent
822b1f296a
commit
ea4151222a
|
|
@ -694,6 +694,176 @@ static int smbdirect_connection_post_recv_io(struct smbdirect_recv_io *msg)
|
|||
return ret;
|
||||
}
|
||||
|
||||
__maybe_unused /* this is temporary while this file is included in others */
|
||||
static void smbdirect_connection_recv_io_done(struct ib_cq *cq, struct ib_wc *wc)
|
||||
{
|
||||
struct smbdirect_recv_io *recv_io =
|
||||
container_of(wc->wr_cqe, struct smbdirect_recv_io, cqe);
|
||||
struct smbdirect_socket *sc = recv_io->socket;
|
||||
const struct smbdirect_socket_parameters *sp = &sc->parameters;
|
||||
struct smbdirect_data_transfer *data_transfer;
|
||||
int current_recv_credits;
|
||||
u16 old_recv_credit_target;
|
||||
u16 credits_requested;
|
||||
u16 credits_granted;
|
||||
u16 flags;
|
||||
u32 data_offset;
|
||||
u32 data_length;
|
||||
u32 remaining_data_length;
|
||||
|
||||
if (unlikely(wc->status != IB_WC_SUCCESS || WARN_ON_ONCE(wc->opcode != IB_WC_RECV))) {
|
||||
if (wc->status != IB_WC_WR_FLUSH_ERR)
|
||||
smbdirect_log_rdma_recv(sc, SMBDIRECT_LOG_ERR,
|
||||
"wc->status=%s (%d) wc->opcode=%d\n",
|
||||
ib_wc_status_msg(wc->status), wc->status, wc->opcode);
|
||||
goto error;
|
||||
}
|
||||
|
||||
smbdirect_log_rdma_recv(sc, SMBDIRECT_LOG_INFO,
|
||||
"recv_io=0x%p type=%d wc status=%s wc opcode %d byte_len=%d pkey_index=%u\n",
|
||||
recv_io, sc->recv_io.expected,
|
||||
ib_wc_status_msg(wc->status), wc->opcode,
|
||||
wc->byte_len, wc->pkey_index);
|
||||
|
||||
/*
|
||||
* Reset timer to the keepalive interval in
|
||||
* order to trigger our next keepalive message.
|
||||
*/
|
||||
sc->idle.keepalive = SMBDIRECT_KEEPALIVE_NONE;
|
||||
mod_delayed_work(sc->workqueue, &sc->idle.timer_work,
|
||||
msecs_to_jiffies(sp->keepalive_interval_msec));
|
||||
|
||||
ib_dma_sync_single_for_cpu(sc->ib.dev,
|
||||
recv_io->sge.addr,
|
||||
recv_io->sge.length,
|
||||
DMA_FROM_DEVICE);
|
||||
|
||||
if (unlikely(wc->byte_len <
|
||||
offsetof(struct smbdirect_data_transfer, padding))) {
|
||||
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
|
||||
"wc->byte_len=%u < %zu\n",
|
||||
wc->byte_len,
|
||||
offsetof(struct smbdirect_data_transfer, padding));
|
||||
goto error;
|
||||
}
|
||||
|
||||
data_transfer = (struct smbdirect_data_transfer *)recv_io->packet;
|
||||
credits_requested = le16_to_cpu(data_transfer->credits_requested);
|
||||
credits_granted = le16_to_cpu(data_transfer->credits_granted);
|
||||
flags = le16_to_cpu(data_transfer->flags);
|
||||
remaining_data_length = le32_to_cpu(data_transfer->remaining_data_length);
|
||||
data_offset = le32_to_cpu(data_transfer->data_offset);
|
||||
data_length = le32_to_cpu(data_transfer->data_length);
|
||||
|
||||
smbdirect_log_incoming(sc, SMBDIRECT_LOG_INFO,
|
||||
"DataIn: %s=%u, %s=%u, %s=0x%x, %s=%u, %s=%u, %s=%u\n",
|
||||
"CreditsRequested",
|
||||
credits_requested,
|
||||
"CreditsGranted",
|
||||
credits_granted,
|
||||
"Flags",
|
||||
flags,
|
||||
"RemainingDataLength",
|
||||
remaining_data_length,
|
||||
"DataOffset",
|
||||
data_offset,
|
||||
"DataLength",
|
||||
data_length);
|
||||
|
||||
if (unlikely(credits_requested == 0)) {
|
||||
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
|
||||
"invalid: credits_requested == 0\n");
|
||||
goto error;
|
||||
}
|
||||
|
||||
if (unlikely(data_offset % 8 != 0)) {
|
||||
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
|
||||
"invalid: data_offset=%u (0x%x) not aligned to 8\n",
|
||||
data_offset, data_offset);
|
||||
goto error;
|
||||
}
|
||||
|
||||
if (unlikely(wc->byte_len < data_offset ||
|
||||
(u64)wc->byte_len < (u64)data_offset + data_length)) {
|
||||
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
|
||||
"wc->byte_len=%u < date_offset=%u + data_length=%u\n",
|
||||
wc->byte_len, data_offset, data_length);
|
||||
goto error;
|
||||
}
|
||||
|
||||
if (unlikely(remaining_data_length > sp->max_fragmented_recv_size ||
|
||||
data_length > sp->max_fragmented_recv_size ||
|
||||
(u64)remaining_data_length + (u64)data_length > (u64)sp->max_fragmented_recv_size)) {
|
||||
smbdirect_log_rdma_event(sc, SMBDIRECT_LOG_ERR,
|
||||
"remaining_data_length=%u + data_length=%u > max_fragmented=%u\n",
|
||||
remaining_data_length, data_length, sp->max_fragmented_recv_size);
|
||||
goto error;
|
||||
}
|
||||
|
||||
if (data_length) {
|
||||
if (sc->recv_io.reassembly.full_packet_received)
|
||||
recv_io->first_segment = true;
|
||||
|
||||
if (remaining_data_length)
|
||||
sc->recv_io.reassembly.full_packet_received = false;
|
||||
else
|
||||
sc->recv_io.reassembly.full_packet_received = true;
|
||||
}
|
||||
|
||||
atomic_dec(&sc->recv_io.posted.count);
|
||||
current_recv_credits = atomic_dec_return(&sc->recv_io.credits.count);
|
||||
|
||||
/*
|
||||
* We take the value from the peer, which is checked to be higher than 0,
|
||||
* but we limit it to the max value we support in order to have
|
||||
* the main logic simpler.
|
||||
*/
|
||||
old_recv_credit_target = sc->recv_io.credits.target;
|
||||
sc->recv_io.credits.target = credits_requested;
|
||||
sc->recv_io.credits.target = min_t(u16, sc->recv_io.credits.target,
|
||||
sp->recv_credit_max);
|
||||
if (credits_granted) {
|
||||
atomic_add(credits_granted, &sc->send_io.credits.count);
|
||||
/*
|
||||
* We have new send credits granted from remote peer
|
||||
* If any sender is waiting for credits, unblock it
|
||||
*/
|
||||
wake_up(&sc->send_io.credits.wait_queue);
|
||||
}
|
||||
|
||||
/* Send an immediate response right away if requested */
|
||||
if (flags & SMBDIRECT_FLAG_RESPONSE_REQUESTED) {
|
||||
smbdirect_log_keep_alive(sc, SMBDIRECT_LOG_INFO,
|
||||
"schedule send of immediate response\n");
|
||||
queue_work(sc->workqueue, &sc->idle.immediate_work);
|
||||
}
|
||||
|
||||
/*
|
||||
* If this is a packet with data playload place the data in
|
||||
* reassembly queue and wake up the reading thread
|
||||
*/
|
||||
if (data_length) {
|
||||
if (current_recv_credits <= (sc->recv_io.credits.target / 4) ||
|
||||
sc->recv_io.credits.target > old_recv_credit_target)
|
||||
queue_work(sc->workqueue, &sc->recv_io.posted.refill_work);
|
||||
|
||||
smbdirect_connection_reassembly_append_recv_io(sc, recv_io, data_length);
|
||||
wake_up(&sc->recv_io.reassembly.wait_queue);
|
||||
} else
|
||||
smbdirect_connection_put_recv_io(recv_io);
|
||||
|
||||
return;
|
||||
|
||||
error:
|
||||
/*
|
||||
* Make sure smbdirect_connection_put_recv_io() does not
|
||||
* start recv_io.posted.refill_work.
|
||||
*/
|
||||
disable_work(&sc->recv_io.posted.refill_work);
|
||||
smbdirect_connection_put_recv_io(recv_io);
|
||||
smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED);
|
||||
}
|
||||
|
||||
static int smbdirect_connection_recv_io_refill(struct smbdirect_socket *sc)
|
||||
{
|
||||
int missing;
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user