github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-23 05:04:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

power: supply: max17042_battery: Use bool for init_complete

Browse Source 
init_complete is a binary state. Change it from int to bool before adding
retry support.

The initialization worker and probe path update the flag while property
reads sample it. Use READ_ONCE() and WRITE_ONCE() to make those lockless
accesses explicit.

Assisted-by: OpenCode:gpt-5.6-sol
Signed-off-by: Vincent Cloutier <vincent@cloutier.co>
Link: https://patch.msgid.link/20260727011319.621794-4-vincent.cloutier@icloud.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Vincent Cloutier 2026-07-26 21:13:01 -04:00 committed by Sebastian Reichel
parent f05e30fd2f
commit e8e7cdd9ce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/power/supply/max17042_battery.c
View File

@ -70,11 +70,11 @@ struct max17042_chip {
enum max170xx_chip_type chip_type;
struct max17042_config_data *config_data;
struct work_struct work;
int init_complete;
int irq;
int task_period;
bool enable_current_sense;
bool enable_por_init;
bool init_complete;
unsigned int r_sns;
int vmin; /* in millivolts */
int vmax; /* in millivolts */
@ -257,7 +257,7 @@ static int max17042_get_property(struct power_supply *psy,
u32 data;
u64 data64;
if (!chip->init_complete)
if (!READ_ONCE(chip->init_complete))
return -EAGAIN;
switch (psp) {
@ -1007,7 +1007,7 @@ static void max17042_init_worker(struct work_struct *work)
return;
}
chip->init_complete = 1;
WRITE_ONCE(chip->init_complete, true);
}
#ifdef CONFIG_OF
@ -1261,7 +1261,7 @@ static int max17042_probe(struct i2c_client *client, struct device *dev, int irq
return ret;
schedule_work(&chip->work);
} else {
chip->init_complete = 1;
WRITE_ONCE(chip->init_complete, true);
}
return 0;