From e889b0e4cafddb3d68c3595dc01b7128fd35fbef Mon Sep 17 00:00:00 2001 From: Oleg Nesterov Date: Sun, 11 Oct 2026 17:13:16 +0200 Subject: [PATCH] io_uring/io-wq: don't call try_to_wake_up() twice in io_wq_worker_wake() io_wq_worker_wake() does an unconditional wake_up_process(). This means that __set_notify_signal() makes no real sense. Change it to use set_tsk_thread_flag(TIF_NOTIFY_SIGNAL) instead to avoid test_and_set_bit() and another wake_up_state(TASK_INTERRUPTIBLE) if NOTIFY_SIGNAL was not set. Perhaps io_wq_worker_wake() can rely on __set_notify_signal() solely, but I don't understand this code enough and this patch doesn't change the current behaviour. Signed-off-by: Oleg Nesterov Reviewed-by: Christian Brauner (Amutable) Link: https://patch.msgid.link/asunjCm5Ovj_YDSp@redhat.com Signed-off-by: Jens Axboe --- io_uring/io-wq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c index 2dadde0ca395..97523ccc7a71 100644 --- a/io_uring/io-wq.c +++ b/io_uring/io-wq.c @@ -976,7 +976,7 @@ static void io_wq_for_each_worker(struct io_wq *wq, static bool io_wq_worker_wake(struct io_worker *worker, void *data) { - __set_notify_signal(worker->task); + set_tsk_thread_flag(worker->task, TIF_NOTIFY_SIGNAL); wake_up_process(worker->task); return false; }