github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-26 08:02:27 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/amd/display: correct clip x assignment in cursor programming

Browse Source 
[why&how]
primary planes for external displays getting incorrect clip
values, detect such a scenario and pass correct parameters

Reviewed-by: Ovidiu (Ovi) Bunea <ovidiu.bunea@amd.com>
Signed-off-by: Ausef Yousof <auyousof@amd.com>
Signed-off-by: Matthew Stewart <matthew.stewart2@amd.com>
Tested-by: Dan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Ausef Yousof 2025-12-01 15:03:10 -05:00 committed by Alex Deucher
parent 1883b2578d
commit e7b09b766a
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/amd/display/dc/dc_hw_types.h
View File

@ -491,6 +491,12 @@ struct dc_cursor_position {
* for each plane.
*/
bool translate_by_source;
/**
* @use_viewport_for_clip: Use viewport position for clip_x calculation
* instead of clip_rect. Required to protect against clip being overwritten
*/
bool use_viewport_for_clip;
};
struct dc_cursor_mi_param {

6
drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c
View File

@ -3666,7 +3666,11 @@ void dcn10_set_cursor_position(struct pipe_ctx *pipe_ctx)
int y_plane = pipe_ctx->plane_state->dst_rect.y;
int x_pos = pos_cpy.x;
int y_pos = pos_cpy.y;
int clip_x = pipe_ctx->plane_state->clip_rect.x;
bool is_primary_plane = (pipe_ctx->plane_state->layer_index == 0);
int clip_x = (pos_cpy.use_viewport_for_clip && is_primary_plane &&
!odm_combine_on && !pipe_split_on && param.viewport.x != 0)
? param.viewport.x : pipe_ctx->plane_state->clip_rect.x;
int clip_width = pipe_ctx->plane_state->clip_rect.width;
if ((pipe_ctx->top_pipe != NULL) || (pipe_ctx->bottom_pipe != NULL)) {