github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 09:36:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

usb: cdns3: plat: fix leaked role switch on core role initialization failure

Browse Source 
Calling usb_role_switch_unregister if core role initialization failure.

Fixes: e4d7362dc9 ("usb: cdns3: Add USBSSP platform driver support")
Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/linux-devicetree/agKaEePSFknhDBg2@nchen-desktop/T/#m21e1d9c1574eb127ce03c0c2a1a49002ce435b52
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
Link: https://patch.msgid.link/20260514010114.2436781-2-peter.chen@cixtech.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Peter Chen 2026-05-14 09:01:14 +08:00 committed by Greg Kroah-Hartman
parent 5bf5e3fba9
commit e663be4218
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/cdns3/cdns3-plat.c
View File

@ -167,7 +167,7 @@ static int cdns3_plat_probe(struct platform_device *pdev)
cdns->host_init = cdns3_plat_host_init;
ret = cdns_core_init_role(cdns);
if (ret)
goto err_cdns_init;
goto err_cdns_init_role;
device_set_wakeup_capable(dev, true);
pm_runtime_set_active(dev);
@ -186,6 +186,9 @@ static int cdns3_plat_probe(struct platform_device *pdev)
return 0;
err_cdns_init_role:
if (cdns->role_sw)
usb_role_switch_unregister(cdns->role_sw);
err_cdns_init:
set_phy_power_off(cdns);
err_phy_power_on: