From e5be89a49c2e0e290d0e52b9105bd58752d004a5 Mon Sep 17 00:00:00 2001 From: Damon Ding Date: Wed, 15 Feb 2023 18:00:22 +0800 Subject: [PATCH] pwm: rockchip: release clk if pinctrl check failed Fixes: 718c02ce1848 ("pwm: rockchip: Make pwm pinctrl setting after pwm enabled") Signed-off-by: Damon Ding Change-Id: Ic67407ee416a24ba368c3cff21aefde0ddf63700 --- drivers/pwm/pwm-rockchip.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 460a65452008..67bab5c7f484 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -395,13 +395,15 @@ static int rockchip_pwm_probe(struct platform_device *pdev) pc->pinctrl = devm_pinctrl_get(&pdev->dev); if (IS_ERR(pc->pinctrl)) { dev_err(&pdev->dev, "Get pinctrl failed!\n"); - return PTR_ERR(pc->pinctrl); + ret = PTR_ERR(pc->pinctrl); + goto err_pclk; } pc->active_state = pinctrl_lookup_state(pc->pinctrl, "active"); if (IS_ERR(pc->active_state)) { dev_err(&pdev->dev, "No active pinctrl state\n"); - return PTR_ERR(pc->active_state); + ret = PTR_ERR(pc->active_state); + goto err_pclk; } platform_set_drvdata(pdev, pc);