From e54650456acaa423021fb9af2c320b0e97690dd8 Mon Sep 17 00:00:00 2001
From: Wyon Bi <bivvy.bi@rock-chips.com>
Date: Mon, 20 Mar 2023 08:43:31 +0000
Subject: [PATCH] mfd: max96745: Reduce i2c operations

Fixes: 83465554242e ("mfd: max96745: Support i2c-mux-idle-disconnect property")
Signed-off-by: Wyon Bi <bivvy.bi@rock-chips.com>
Change-Id: Ib6cc9b197561bf1326442cebbd9844af3853d06a
---
 drivers/mfd/max96745.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/max96745.c b/drivers/mfd/max96745.c
index d973f8991f4e..53cf69a5521b 100644
--- a/drivers/mfd/max96745.c
+++ b/drivers/mfd/max96745.c
@@ -18,6 +18,7 @@ struct max96745 {
 	struct device *dev;
 	struct regmap *regmap;
 	struct i2c_mux_core *muxc;
+	bool idle_disc;
 	struct gpio_desc *enable_gpio;
 	struct gpio_desc *lock_gpio;
 };
@@ -63,6 +64,9 @@ static int max96745_select(struct i2c_mux_core *muxc, u32 chan)
 {
 	struct max96745 *max96745 = dev_get_drvdata(muxc->dev);
 
+	if (!max96745->idle_disc)
+		return 0;
+
 	if (chan == 1)
 		regmap_update_bits(max96745->regmap, 0x0086, DIS_REM_CC,
 				   FIELD_PREP(DIS_REM_CC, 0));
@@ -77,6 +81,9 @@ static int max96745_deselect(struct i2c_mux_core *muxc, u32 chan)
 {
 	struct max96745 *max96745 = dev_get_drvdata(muxc->dev);
 
+	if (!max96745->idle_disc)
+		return 0;
+
 	if (chan == 1)
 		regmap_update_bits(max96745->regmap, 0x0086, DIS_REM_CC,
 				   FIELD_PREP(DIS_REM_CC, 1));
@@ -109,10 +116,12 @@ static void max96745_power_on(struct max96745 *max96745)
 		msleep(200);
 	}
 
-	regmap_update_bits(max96745->regmap, 0x0076, DIS_REM_CC,
-			   FIELD_PREP(DIS_REM_CC, 1));
-	regmap_update_bits(max96745->regmap, 0x0086, DIS_REM_CC,
-			   FIELD_PREP(DIS_REM_CC, 1));
+	if (max96745->idle_disc) {
+		regmap_update_bits(max96745->regmap, 0x0076, DIS_REM_CC,
+				   FIELD_PREP(DIS_REM_CC, 1));
+		regmap_update_bits(max96745->regmap, 0x0086, DIS_REM_CC,
+				   FIELD_PREP(DIS_REM_CC, 1));
+	}
 }
 
 static ssize_t line_fault_monitor_show(struct device *device,
@@ -198,7 +207,6 @@ static int max96745_i2c_probe(struct i2c_client *client)
 	struct device_node *child;
 	struct max96745 *max96745;
 	unsigned int nr = 0;
-	bool idle_disc;
 	int ret;
 
 	for_each_available_child_of_node(dev->of_node, child) {
@@ -212,11 +220,11 @@ static int max96745_i2c_probe(struct i2c_client *client)
 	if (!max96745)
 		return -ENOMEM;
 
-	idle_disc = device_property_read_bool(dev, "i2c-mux-idle-disconnect");
+	max96745->idle_disc = device_property_read_bool(dev, "i2c-mux-idle-disconnect");
 
 	max96745->muxc = i2c_mux_alloc(client->adapter, dev, nr,
 				       0, I2C_MUX_LOCKED, max96745_select,
-				       idle_disc ? max96745_deselect : NULL);
+				       max96745_deselect);
 	if (!max96745->muxc)
 		return -ENOMEM;