github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 04:34:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: lapbether: check register_netdevice_notifier() error in lapbeth_init_driver()

Browse Source 
lapbeth_init_driver() ignores register_netdevice_notifier() errors and
always returns success, which can leave the module loaded without its
netdev notifier registered.

Check the error and remove the packet type on failure.

This is a future looking check, register_netdevice_notifier()
only fails on double registration or if the registered notifier
itself returns an error.

Signed-off-by: Minhong He <heminhong@kylinos.cn>
Link: https://patch.msgid.link/20260803085936.142160-1-heminhong@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Minhong He 2026-08-03 16:59:36 +08:00 committed by Jakub Kicinski
parent d13bb65dd2
commit e43e9d7cab
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/wan/lapbether.c
View File

@ -497,9 +497,15 @@ static const char banner[] __initconst =
static int __init lapbeth_init_driver(void)
{
int err;
dev_add_pack(&lapbeth_packet_type);
register_netdevice_notifier(&lapbeth_dev_notifier);
err = register_netdevice_notifier(&lapbeth_dev_notifier);
if (err) {
dev_remove_pack(&lapbeth_packet_type);
return err;
}
printk(banner);