mirror of
https://github.com/torvalds/linux.git
synced 2026-06-04 20:46:48 +02:00
USB: serial: cypress_m8: fix memory corruption with small endpoint
Make sure that the interrupt-out endpoint max packet size is at least
eight bytes to avoid user-controlled slab corruption or NULL-pointer
dereference should a malicious device report a smaller size.
Fixes: 3416eaa1f8 ("USB: cypress_m8: Packet format is separate from characteristic size")
Cc: stable@vger.kernel.org # 2.6.26
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
parent
689f2facc6
commit
e1a9d791fd
|
|
@ -445,6 +445,14 @@ static int cypress_generic_port_probe(struct usb_serial_port *port)
|
|||
return -ENODEV;
|
||||
}
|
||||
|
||||
/*
|
||||
* The buffer must be large enough for the one or two-byte header (and
|
||||
* following data), but assume anything smaller than eight bytes is
|
||||
* broken.
|
||||
*/
|
||||
if (port->interrupt_out_size < 8)
|
||||
return -EINVAL;
|
||||
|
||||
priv = kzalloc_obj(struct cypress_private);
|
||||
if (!priv)
|
||||
return -ENOMEM;
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user