github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-11 20:13:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

OPP updates for 7.3-rc2

Browse Source 
- Fix potential multiplication overflow when calculating freq in OPP
   core (Colin Ian King).
 
 - Fix use after free in _update_opp_table_clk() (Peter Griffin).
 
 - Use %pe to print symbolic error name (Sumeet Pawnikar).
 -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEx73Crsp7f6M6scA70rkcPK6BEhwFAmqg6SAACgkQ0rkcPK6B
 EhxfIhAAiZ1MRiCnpxWJXo3dt37MGjzB6UrZ/S+PR51i4EyV1aLkU9gfgQA3T+Tz
 pnPTGzvTRUYNf0ASNXR0faDUYffbfgW9k4RhZB5WKa/gmYOlgvkDRkNIH5WhSBr7
 wmoSKjL93FrEiwdDHbOqacQUqdAyZS0t4HsDSmDGaHvAzuR9jyHyvEg448nZ3leA
 +saVPt/PMyhid9v/DqEOfz4WLCfMAhrEvbbIl0qn0ySut8PLP95u+sXVpbUi3x1d
 cKeNfwXjjEyFhqLptByr8dr6G9GUu2GY8jvwPRLKN9gLglq+lKo8ZMm1vWOSQ+Qt
 D+vbXShKz33ijNhRy/acAsYGuz6aWqLQirlqq1l3+XQLdAOaHN5s/8cnXfUcieBJ
 e3oXDJA6bwFMMi0LA15TMgfUn5S9Fx3Cr4PVctdhjgbFfyATDDSgXSGEP0GJr3xI
 ChoYTSXDn7vnBb1jo+HWBfw4nqrMScBTksU70e6dKlvk1SyHWI2MM2k3qoSCgh4j
 /s3FtLj31nstDuyDOvxGkhBW5qpnX+iiLwq6TzKLL6Sr/9AqoV8TcrOpTLizqzXW
 0hkb/fUJEgtwN1gTm3Un7jStpjE5Gki6HWeCRPV+ybo+TbxfFBwemDE1TqCZ8GHY
 7jhaa/ioxR6qPEH8LdQ9lTCrxma9eXzP814M3xXaqgAD/mjr6S8=
 =78fU
 -----END PGP SIGNATURE-----

Merge tag 'opp-updates-7.3.rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm

Merge OPP updates for 7.3-rc3 from Viresh Kumar:

"- Fix potential multiplication overflow when calculating freq in OPP
   core (Colin Ian King).

 - Fix use after free in _update_opp_table_clk() (Peter Griffin).

 - Use %pe to print symbolic error name (Sumeet Pawnikar)."

* tag 'opp-updates-7.3.rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm:
  opp: fix use after free in _update_opp_table_clk()
  opp: Use %pe to print symbolic error name
  OPP: of: Fix potential multiplication overflow when calculating freq
This commit is contained in:
Rafael J. Wysocki 2026-09-09 19:03:00 +02:00
commit e06cb12e1e
2 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/opp/core.c
View File

@ -453,8 +453,8 @@ int dev_pm_opp_get_opp_count(struct device *dev)
_find_opp_table(dev);
if (IS_ERR(opp_table)) {
dev_dbg(dev, "%s: OPP table not found (%ld)\n",
__func__, PTR_ERR(opp_table));
dev_dbg(dev, "%s: OPP table not found (%pe)\n",
__func__, opp_table);
return PTR_ERR(opp_table);
}
@ -611,8 +611,8 @@ _find_key(struct device *dev, unsigned long *key, int index, bool available,
_find_opp_table(dev);
if (IS_ERR(opp_table)) {
dev_err(dev, "%s: OPP table not found (%ld)\n", __func__,
PTR_ERR(opp_table));
dev_err(dev, "%s: OPP table not found (%pe)\n", __func__,
opp_table);
return ERR_CAST(opp_table);
}
@ -722,8 +722,8 @@ struct dev_pm_opp *dev_pm_opp_find_key_exact(struct device *dev,
struct opp_table *opp_table __free(put_opp_table) = _find_opp_table(dev);
if (IS_ERR(opp_table)) {
dev_err(dev, "%s: OPP table not found (%ld)\n", __func__,
PTR_ERR(opp_table));
dev_err(dev, "%s: OPP table not found (%pe)\n", __func__,
opp_table);
return ERR_CAST(opp_table);
}
@ -1036,8 +1036,8 @@ static int _set_opp_voltage(struct device *dev, struct regulator *reg,
/* Regulator not available for device */
if (IS_ERR(reg)) {
dev_dbg(dev, "%s: regulator not available: %ld\n", __func__,
PTR_ERR(reg));
dev_dbg(dev, "%s: regulator not available: %pe\n", __func__,
reg);
return 0;
}
@ -1448,8 +1448,8 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
temp_freq = freq;
opp = _find_freq_ceil(opp_table, &temp_freq);
if (IS_ERR(opp)) {
dev_err(dev, "%s: failed to find OPP for freq %lu (%ld)\n",
__func__, freq, PTR_ERR(opp));
dev_err(dev, "%s: failed to find OPP for freq %lu (%pe)\n",
__func__, freq, opp);
return PTR_ERR(opp);
}
@ -1581,6 +1581,8 @@ static struct opp_table *_update_opp_table_clk(struct device *dev,
struct opp_table *opp_table,
bool getclk)
{
int ret;
/*
* Return early if we don't need to get clk or we have already done it
* earlier.
@ -1607,9 +1609,9 @@ static struct opp_table *_update_opp_table_clk(struct device *dev,
opp_table->clk = clk_get_optional(dev, NULL);
if (IS_ERR(opp_table->clk)) {
ret = dev_err_probe(dev, PTR_ERR(opp_table->clk), "Couldn't find clock\n");
dev_pm_opp_put_opp_table(opp_table);
dev_err_probe(dev, PTR_ERR(opp_table->clk), "Couldn't find clock\n");
return ERR_CAST(opp_table->clk);
return ERR_PTR(ret);
}
if (opp_table->clk)
@ -2869,8 +2871,8 @@ static int _opp_set_availability(struct device *dev, unsigned long freq,
struct dev_pm_opp *opp __free(put_opp) = ERR_PTR(-ENODEV), *tmp_opp;
if (IS_ERR(opp_table)) {
dev_warn(dev, "%s: Device OPP not found (%ld)\n", __func__,
PTR_ERR(opp_table));
dev_warn(dev, "%s: Device OPP not found (%pe)\n", __func__,
opp_table);
return PTR_ERR(opp_table);
}

6
drivers/opp/of.c
View File

@ -1039,7 +1039,7 @@ static int _of_add_opp_table_v1(struct device *dev, struct opp_table *opp_table)
val = prop->value;
while (nr) {
unsigned long freq = be32_to_cpup(val++) * 1000;
unsigned long freq = (unsigned long)be32_to_cpup(val++) * 1000;
unsigned long volt = be32_to_cpup(val++);
struct dev_pm_opp_data data = {
.freq = freq,
@ -1345,8 +1345,8 @@ int of_get_required_opp_performance_state(struct device_node *np, int index)
_find_table_of_opp_np(required_np);
if (IS_ERR(opp_table)) {
pr_err("%s: Failed to find required OPP table %pOF: %ld\n",
__func__, np, PTR_ERR(opp_table));
pr_err("%s: Failed to find required OPP table %pOF: %pe\n",
__func__, np, opp_table);
return PTR_ERR(opp_table);
}