github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-26 16:12:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset

Browse Source 
Split the GGTT PTE readout to a separate function, this is useful for
adding testcases in the next commit, and also cleaner than manually
reading out GGTT.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Link: https://lore.kernel.org/r/20250505121924.921544-10-dev@lankhorst.se
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
This commit is contained in:
Maarten Lankhorst 2025-05-05 14:19:22 +02:00
parent 0c52d72252
commit e0096fdcf8
3 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/xe/display/xe_plane_initial.c
View File

@ -87,12 +87,8 @@ initial_plane_bo(struct xe_device *xe,
base = round_down(plane_config->base, page_size);
if (IS_DGFX(xe)) {
u64 __iomem *gte = tile0->mem.ggtt->gsm;
u64 pte;
u64 pte = xe_ggtt_read_pte(tile0->mem.ggtt, base);
gte += base / XE_PAGE_SIZE;
pte = ioread64(gte);
if (!(pte & XE_GGTT_PTE_DM)) {
drm_err(&xe->drm,
"Initial plane programming missing DM bit\n");

12
drivers/gpu/drm/xe/xe_ggtt.c
View File

@ -957,3 +957,15 @@ u64 xe_ggtt_encode_pte_flags(struct xe_ggtt *ggtt,
{
return ggtt->pt_ops->pte_encode_flags(bo, pat_index);
}
/**
* xe_ggtt_read_pte - Read a PTE from the GGTT
* @ggtt: &xe_ggtt
* @offset: the offset for which the mapping should be read.
*
* Used by testcases, and by display reading out an inherited bios FB.
*/
u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset)
{
return ioread64(ggtt->gsm + (offset / XE_PAGE_SIZE));
}

1
drivers/gpu/drm/xe/xe_ggtt.h
View File

@ -51,5 +51,6 @@ void xe_ggtt_might_lock(struct xe_ggtt *ggtt);
#endif
u64 xe_ggtt_encode_pte_flags(struct xe_ggtt *ggtt, struct xe_bo *bo, u16 pat_index);
u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset);
#endif