github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-01 02:53:36 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: phy: marvell: Fix 88e1510 downshift counter errata

Browse Source 
The 88e1510 PHY has an erratum where the phy downshift counter is not
cleared after phy being suspended(BMCR_PDOWN set) and then later
resumed(BMCR_PDOWN cleared). This can cause the gigabit link to
intermittently downshift to a lower speed.

Disabling and re-enabling the downshift feature clears the counter,
allowing the PHY to retry gigabit link negotiation up to the programmed
retry count times before downshifting. This behavior has been observed
on copper links.

Signed-off-by: Rohan G Thomas <rohan.g.thomas@altera.com>
Reviewed-by: Matthew Gerlach <matthew.gerlach@altera.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250906-marvell_fix-v2-1-f6efb286937f@altera.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Rohan G Thomas 2025-09-06 10:33:31 +08:00 committed by Jakub Kicinski
parent 214da63451
commit deb105f498
1 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
drivers/net/phy/marvell.c
View File

@ -1902,6 +1902,43 @@ static int marvell_resume(struct phy_device *phydev)
return err;
}
/* m88e1510_resume
*
* The 88e1510 PHY has an erratum where the phy downshift counter is not cleared
* after phy being suspended(BMCR_PDOWN set) and then later resumed(BMCR_PDOWN
* cleared). This can cause the link to intermittently downshift to a lower speed.
*
* Disabling and re-enabling the downshift feature clears the counter, allowing
* the PHY to retry gigabit link negotiation up to the programmed retry count
* before downshifting. This behavior has been observed on copper links.
*/
static int m88e1510_resume(struct phy_device *phydev)
{
int err;
u8 cnt = 0;
err = marvell_resume(phydev);
if (err < 0)
return err;
/* read downshift counter value */
err = m88e1011_get_downshift(phydev, &cnt);
if (err < 0)
return err;
if (cnt) {
/* downshift disabled */
err = m88e1011_set_downshift(phydev, 0);
if (err < 0)
return err;
/* downshift enabled, with previous counter value */
err = m88e1011_set_downshift(phydev, cnt);
}
return err;
}
static int marvell_aneg_done(struct phy_device *phydev)
{
int retval = phy_read(phydev, MII_M1011_PHY_STATUS);
@ -3923,7 +3960,7 @@ static struct phy_driver marvell_drivers[] = {
.handle_interrupt = marvell_handle_interrupt,
.get_wol = m88e1318_get_wol,
.set_wol = m88e1318_set_wol,
.resume = marvell_resume,
.resume = m88e1510_resume,
.suspend = marvell_suspend,
.read_page = marvell_read_page,
.write_page = marvell_write_page,