github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 17:13:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

tty: vcc: Drop impossible to hit WARN_ON

Browse Source 
vcc_get() returns the port that has provided port->index. As the port that
is about to be removed isn't removed yet this trivially will find this
port. So simplify the call to not assign an identical value to the port
pointer and drop the warning that is never hit.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Uwe Kleine-König 2021-01-14 18:57:18 +01:00 committed by David S. Miller
parent a57cdeb369
commit da54472654
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/tty/vcc.c
View File

@ -695,12 +695,9 @@ static int vcc_remove(struct vio_dev *vdev)
tty_vhangup(port->tty);
/* Get exclusive reference to VCC, ensures that there are no other
* clients to this port
* clients to this port. This cannot fail.
*/
port = vcc_get(port->index, true);
if (WARN_ON(!port))
return -ENODEV;
vcc_get(port->index, true);
tty_unregister_device(vcc_tty_driver, port->index);