github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 11:37:06 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

wifi: mt76: mt7996: prevent uninit return in mt7996_mac_sta_add_links

Browse Source 
If link_conf_dereference_protected() or mt7996_vif_link()
or link_sta_dereference_protected() fail the code jumps to
the error_unlink label and returns ret which is uninitialised.

Fix this by setting err before jumping to error_unlink.

Fixes: c7e4fc3624 ("wifi: mt76: mt7996: Update mt7996_mcu_add_sta to MLO support")
Fixes: dd82a9e02c ("wifi: mt76: mt7996: Rely on mt7996_sta_link in sta_add/sta_remove callbacks")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Link: https://patch.msgid.link/20250421110550.9839-1-qasdev00@gmail.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>
This commit is contained in:
Qasim Ijaz 2025-04-21 12:05:50 +01:00 committed by Felix Fietkau
parent 3dbfb8abe3
commit d9bc625861
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/wireless/mediatek/mt76/mt7996/main.c
View File

@ -998,16 +998,22 @@ mt7996_mac_sta_add_links(struct mt7996_dev *dev, struct ieee80211_vif *vif,
continue;
link_conf = link_conf_dereference_protected(vif, link_id);
if (!link_conf)
if (!link_conf) {
err = -EINVAL;
goto error_unlink;
}
link = mt7996_vif_link(dev, vif, link_id);
if (!link)
if (!link) {
err = -EINVAL;
goto error_unlink;
}
link_sta = link_sta_dereference_protected(sta, link_id);
if (!link_sta)
if (!link_sta) {
err = -EINVAL;
goto error_unlink;
}
err = mt7996_mac_sta_init_link(dev, link_conf, link_sta, link,
link_id);