github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/amd/display: add KUnit tests for DPCD poweroff delay

Browse Source 
[WHAT]
Add KUnit tests for amdgpu_dm_apply_delay_after_dpcd_poweroff covering
the NULL-sink early return, the zero-wait skip path, and the non-zero
wait interval.

Assisted-by: Copilot:Claude-Opus-4.8
Reviewed-by: Bhawanpreet Lakha <bhawanpreet.lakha@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Wayne Lin <wayne.lin@amd.com>
Tested-by: Dan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Alex Hung 2026-07-06 19:23:04 -06:00 committed by Alex Deucher
parent 753f41b30f
commit d79f3c7fe1
2 changed files with 49 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
View File

@ -1918,6 +1918,7 @@ void amdgpu_dm_apply_delay_after_dpcd_poweroff(struct amdgpu_device *adev,
ppatch->wait_after_dpcd_poweroff_ms / 1000);
}
}
EXPORT_IF_KUNIT(amdgpu_dm_apply_delay_after_dpcd_poweroff);
/**
* amdgpu_dm_dump_links_and_sinks - Debug dump of all DC links and their sinks

48
drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c
View File

@ -1997,6 +1997,50 @@ static void dm_test_should_disable_stutter_revision_differs(struct kunit *test)
KUNIT_EXPECT_FALSE(test, dm_should_disable_stutter(pdev));
}
/* Tests for amdgpu_dm_apply_delay_after_dpcd_poweroff() */
/**
* dm_test_apply_delay_null_sink - Test a NULL sink returns without delay
* @test: The KUnit test context
*/
static void dm_test_apply_delay_null_sink(struct kunit *test)
{
/* NULL sink: early return, no delay, no dereference */
amdgpu_dm_apply_delay_after_dpcd_poweroff(NULL, NULL);
}
/**
* dm_test_apply_delay_zero_wait - Test a zero wait interval skips the delay
* @test: The KUnit test context
*/
static void dm_test_apply_delay_zero_wait(struct kunit *test)
{
struct dc_sink *sink;
sink = kunit_kzalloc(test, sizeof(*sink), GFP_KERNEL);
KUNIT_ASSERT_NOT_NULL(test, sink);
/* wait == 0: no msleep, adev is unused so NULL is safe */
sink->edid_caps.panel_patch.wait_after_dpcd_poweroff_ms = 0;
amdgpu_dm_apply_delay_after_dpcd_poweroff(NULL, sink);
}
/**
* dm_test_apply_delay_nonzero_wait - Test a non-zero wait interval executes delay path
* @test: The KUnit test context
*/
static void dm_test_apply_delay_nonzero_wait(struct kunit *test)
{
struct amdgpu_device *adev = dm_kunit_alloc_adev(test);
struct dc_sink *sink;
sink = kunit_kzalloc(test, sizeof(*sink), GFP_KERNEL);
KUNIT_ASSERT_NOT_NULL(test, sink);
sink->edid_caps.panel_patch.wait_after_dpcd_poweroff_ms = 1;
amdgpu_dm_apply_delay_after_dpcd_poweroff(adev, sink);
}
static struct kunit_case amdgpu_dm_tests[] = {
/* Simple DM callbacks */
KUNIT_CASE(dm_test_is_idle),
@ -2106,6 +2150,10 @@ static struct kunit_case amdgpu_dm_tests[] = {
KUNIT_CASE(dm_test_should_disable_stutter_match),
KUNIT_CASE(dm_test_should_disable_stutter_no_match),
KUNIT_CASE(dm_test_should_disable_stutter_revision_differs),
/* amdgpu_dm_apply_delay_after_dpcd_poweroff */
KUNIT_CASE(dm_test_apply_delay_null_sink),
KUNIT_CASE(dm_test_apply_delay_zero_wait),
KUNIT_CASE(dm_test_apply_delay_nonzero_wait),
{}
};